Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cenum_impl_drop_cast a hard error #135964

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Make cenum_impl_drop_cast a hard error #135964

merged 1 commit into from
Feb 6, 2025
+12 −181

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Jan 24, 2025

This changes the cenum_impl_drop_cast lint to be a hard error. This lint has been deny-by-default and warning in dependencies since #97652 about 2.5 years ago.

Closes #73333

@ehuss
Make cenum_impl_drop_cast a hard error
e0bbeb7 
This changes the `cenum_impl_drop_cast` lint to be a hard error. This
lint has been deny-by-default and warning in dependencies since
rust-lang#97652 about 2.5 years ago.

Closes rust-lang#73333
@rustbot
Copy link
Collaborator

rustbot commented Jan 24, 2025

r? @Nadrieril

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 24, 2025
@ehuss
Copy link
Contributor Author

ehuss commented Jan 24, 2025

cc @traviscross @RalfJung

@traviscross traviscross added T-lang Relevant to the language team, which will review and decide on the PR/issue. I-lang-nominated Nominated for discussion during a lang team meeting. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 24, 2025
@traviscross
Copy link
Contributor

traviscross commented Jan 24, 2025 •
edited
Loading

@rfcbot fcp merge

We decided in 2016 that...

We like the idea of making it an error to coerce an enum to an integer if that enum type supports Drop -- presuming it doesn't have impact in practice (which seems likely).

Seems maybe time to follow all the way through.

@rfcbot
Copy link

rfcbot commented Jan 24, 2025 •
edited by scottmcm
Loading

Team member @traviscross has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jan 24, 2025
@nikomatsakis
Copy link
Contributor

@rfcbot reviewed

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Jan 24, 2025
@rfcbot
Copy link

rfcbot commented Jan 24, 2025

🔔 This is now entering its final comment period, as per the review above. 🔔

@traviscross traviscross removed the I-lang-nominated Nominated for discussion during a lang team meeting. label Jan 27, 2025
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Feb 3, 2025
@rfcbot
Copy link

rfcbot commented Feb 3, 2025

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@rustbot rustbot mentioned this pull request Feb 3, 2025
Open
3 tasks
@Nadrieril
Copy link
Member

👍

@bors r+

@bors
Copy link
Contributor

bors commented Feb 4, 2025

📌 Commit e0bbeb7 has been approved by Nadrieril

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2025
ehuss added a commit to ickk/rust-lang-reference that referenced this pull request Feb 4, 2025
@ehuss
Update now that cenum_impl_drop_cast is a hard error
350536c 
cenum_impl_drop_cast has been changed to a hard error in
rust-lang/rust#135964
ehuss added a commit to ickk/rust-lang-reference that referenced this pull request Feb 4, 2025
@ehuss
Update now that cenum_impl_drop_cast is a hard error
4675c25 
cenum_impl_drop_cast has been changed to a hard error in
rust-lang/rust#135964
@ehuss ehuss mentioned this pull request Feb 4, 2025
Merged
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Feb 5, 2025
@jieyouxu
Rollup merge of rust-lang#135964 - ehuss:cenum_impl_drop_cast, r=Nadr…
8ee0052 
…ieril

Make cenum_impl_drop_cast a hard error

This changes the `cenum_impl_drop_cast` lint to be a hard error. This lint has been deny-by-default and warning in dependencies since rust-lang#97652 about 2.5 years ago.

Closes rust-lang#73333
@jieyouxu jieyouxu mentioned this pull request Feb 5, 2025
Closed
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Feb 5, 2025
@jieyouxu
Rollup merge of rust-lang#135964 - ehuss:cenum_impl_drop_cast, r=Nadr…
f9d9b84 
…ieril

Make cenum_impl_drop_cast a hard error

This changes the `cenum_impl_drop_cast` lint to be a hard error. This lint has been deny-by-default and warning in dependencies since rust-lang#97652 about 2.5 years ago.

Closes rust-lang#73333
This was referenced Feb 5, 2025
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 5, 2025
@bors
Auto merge of rust-lang#136572 - jieyouxu:rollup-mtyaisw, r=jieyouxu
2d09365 
Rollup of 12 pull requests

Successful merges:

 - rust-lang#132547 (cg_gcc: Directly use rustc_abi instead of reexports)
 - rust-lang#135572 (tests: Port `split-debuginfo` to rmake.rs)
 - rust-lang#135964 (Make cenum_impl_drop_cast a hard error)
 - rust-lang#136154 (Use +secure-plt for powerpc-unknown-linux-gnu{,spe})
 - rust-lang#136304 (Reject negative literals for unsigned or char types in pattern ranges and literals)
 - rust-lang#136418 (uefi: process: Add support for command environment variables)
 - rust-lang#136449 (std: move network code into `sys`)
 - rust-lang#136517 (implement inherent str constructors)
 - rust-lang#136536 (Rename and Move some UI tests to more suitable subdirs)
 - rust-lang#136537 (Update `compiler-builtins` to 0.1.145)
 - rust-lang#136555 (Rename `slice::take...` methods to `split_off...`)
 - rust-lang#136567 (Arbitrary self types v2: recursion test)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 5, 2025
@bors
Auto merge of rust-lang#136572 - jieyouxu:rollup-mtyaisw, r=jieyouxu
6741521 
Rollup of 12 pull requests

Successful merges:

 - rust-lang#132547 (cg_gcc: Directly use rustc_abi instead of reexports)
 - rust-lang#135572 (tests: Port `split-debuginfo` to rmake.rs)
 - rust-lang#135964 (Make cenum_impl_drop_cast a hard error)
 - rust-lang#136154 (Use +secure-plt for powerpc-unknown-linux-gnu{,spe})
 - rust-lang#136304 (Reject negative literals for unsigned or char types in pattern ranges and literals)
 - rust-lang#136418 (uefi: process: Add support for command environment variables)
 - rust-lang#136449 (std: move network code into `sys`)
 - rust-lang#136517 (implement inherent str constructors)
 - rust-lang#136536 (Rename and Move some UI tests to more suitable subdirs)
 - rust-lang#136537 (Update `compiler-builtins` to 0.1.145)
 - rust-lang#136555 (Rename `slice::take...` methods to `split_off...`)
 - rust-lang#136567 (Arbitrary self types v2: recursion test)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit def4460 into rust-lang:master Feb 6, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 6, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 6, 2025
@rust-timer
Unrolled build for rust-lang#135964
6cc1998 
Rollup merge of rust-lang#135964 - ehuss:cenum_impl_drop_cast, r=Nadrieril

Make cenum_impl_drop_cast a hard error

This changes the `cenum_impl_drop_cast` lint to be a hard error. This lint has been deny-by-default and warning in dependencies since rust-lang#97652 about 2.5 years ago.

Closes rust-lang#73333
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Nadrieril Nadrieril

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-lang Relevant to the language team, which will review and decide on the PR/issue. to-announce Announce this issue on triage meeting
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.

Tracking issue for future-incompatibility lint cenum_impl_drop_cast
7 participants
@ehuss @rustbot @traviscross @rfcbot @nikomatsakis @Nadrieril @bors