Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy Python improvements #135950

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Tidy Python improvements #135950

merged 4 commits into from
Jan 24, 2025

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jan 23, 2025

Fixes display of Python formatting diffs in tidy, and refactors the code to make it simpler and more robust. Also documents Python formatting and linting in the Rustc dev guide.

Fixes: #135942

r? @onur-ozkan

@rustbot
Copy link
Collaborator

rustbot commented Jan 23, 2025

Could not assign reviewer from: onur-ozkan.
User(s) onur-ozkan are either the PR author, already assigned, or on vacation. Please use r? to specify someone else to assign.

@rustbot
Copy link
Collaborator

rustbot commented Jan 23, 2025

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-rustc-dev-guide Area: rustc-dev-guide A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jan 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 23, 2025

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol

@Kobzol Kobzol mentioned this pull request Jan 23, 2025
Closed
onur-ozkan
onur-ozkan approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to r=me

src/doc/rustc-dev-guide/src/conventions.md Outdated Show resolved Hide resolved
@onur-ozkan
Copy link
Member

Could not assign reviewer from: onur-ozkan. User(s) onur-ozkan are either the PR author, already assigned, or on vacation. Please use r? to specify someone else to assign.

I guess rustbot doesn't allow users from vacation list to r other people 🤔

@clubby789
Copy link
Contributor

test:
r? @onur-ozkan

@rustbot
Copy link
Collaborator

rustbot commented Jan 23, 2025

Could not assign reviewer from: onur-ozkan.
User(s) onur-ozkan are either the PR author, already assigned, or on vacation. Please use r? to specify someone else to assign.

@jieyouxu
Copy link
Member

Asked about this in the compiler thread

@jieyouxu
Copy link
Member

r? @onur-ozkan (experiment again)

@rustbot
Copy link
Collaborator

rustbot commented Jan 24, 2025

Could not assign reviewer from: onur-ozkan.
User(s) onur-ozkan are either the PR author, already assigned, or on vacation. Please use r? to specify someone else to assign.

@jieyouxu
Copy link
Member

Fine. I am rustbot.

@jieyouxu jieyouxu assigned onur-ozkan and unassigned clubby789 Jan 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 24, 2025

onur-ozkan has insufficient capacity to be assigned the pull request at this time. PR assignment has been reverted.

Please choose another assignee.

(see documentation)

@onur-ozkan
Copy link
Member

onur-ozkan has insufficient capacity to be assigned the pull request at this time. PR assignment has been reverted.

Please choose another assignee.

(see documentation)

Dude it's fine just let me take it

@onur-ozkan onur-ozkan self-assigned this Jan 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 24, 2025

onur-ozkan has insufficient capacity to be assigned the pull request at this time. PR assignment has been reverted.

Please choose another assignee.

(see documentation)

@jieyouxu jieyouxu self-assigned this Jan 24, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Jan 24, 2025 •
edited
Loading

But why can I assign me

@bors
Copy link
Contributor

bors commented Jan 24, 2025

📌 Commit 0f334ec has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 24, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 24, 2025
@matthiaskrgr
Rollup merge of rust-lang#135950 - Kobzol:tidy-python-improvements, r…
6f8f35a 
…=onur-ozkan

Tidy Python improvements

Fixes display of Python formatting diffs in tidy, and refactors the code to make it simpler and more robust. Also documents Python formatting and linting in the Rustc dev guide.

Fixes: rust-lang#135942

r? `@onur-ozkan`
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 24, 2025
Closed
@apiraino
Copy link
Contributor

r? @onur-ozkan

@rustbot
Copy link
Collaborator

rustbot commented Jan 24, 2025

Could not assign reviewer from: onur-ozkan.
User(s) onur-ozkan are either the PR author, already assigned, or on vacation. Please use r? to specify someone else to assign.

@apiraino apiraino requested review from apiraino and onur-ozkan and removed request for apiraino and onur-ozkan January 24, 2025 13:07
@apiraino
Copy link
Contributor

apiraino commented Jan 24, 2025 •
edited
Loading

r? @apiraino

@rustbot
Copy link
Collaborator

rustbot commented Jan 24, 2025

Could not assign reviewer from: apir.
User(s) apir are either the PR author, already assigned, or on vacation. Please use r? to specify someone else to assign.

@apiraino
Copy link
Contributor

r? @onur-ozkan

@rustbot
Copy link
Collaborator

rustbot commented Jan 24, 2025

Could not assign reviewer from: onur-ozkan.
User(s) onur-ozkan are either the PR author, already assigned, or on vacation. Please use r? to specify someone else to assign.

@apiraino apiraino assigned jieyouxu and unassigned apiraino Jan 24, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 24, 2025
@bors
Auto merge of rust-lang#135986 - matthiaskrgr:rollup-eszobzi, r=matth…
62a7968 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#135295 (Check empty SIMD vector in inline asm)
 - rust-lang#135873 (coverage: Prepare for upcoming changes to counter creation)
 - rust-lang#135926 (Implement `needs-subprocess` directive, and cleanup a bunch of tests to use `needs-{subprocess,threads}`)
 - rust-lang#135950 (Tidy Python improvements)
 - rust-lang#135956 (Make `Vec::pop_if` a bit more presentable)
 - rust-lang#135966 ([AIX] Allow different sized load and store in `tests/assembly/powerpc64-struct-abi.rs`)
 - rust-lang#135983 (Doc difference between extend and extend_from_slice)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 24, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 24, 2025
@bors
Auto merge of rust-lang#136000 - matthiaskrgr:rollup-j6ge32r, r=matth…
1e9b017 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#135873 (coverage: Prepare for upcoming changes to counter creation)
 - rust-lang#135926 (Implement `needs-subprocess` directive, and cleanup a bunch of tests to use `needs-{subprocess,threads}`)
 - rust-lang#135950 (Tidy Python improvements)
 - rust-lang#135956 (Make `Vec::pop_if` a bit more presentable)
 - rust-lang#135966 ([AIX] Allow different sized load and store in `tests/assembly/powerpc64-struct-abi.rs`)
 - rust-lang#135983 (Doc difference between extend and extend_from_slice)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c459b17 into rust-lang:master Jan 24, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 24, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 24, 2025
@rust-timer
Unrolled build for rust-lang#135950
0d2d726 
Rollup merge of rust-lang#135950 - Kobzol:tidy-python-improvements, r=onur-ozkan

Tidy Python improvements

Fixes display of Python formatting diffs in tidy, and refactors the code to make it simpler and more robust. Also documents Python formatting and linting in the Rustc dev guide.

Fixes: rust-lang#135942

r? `@onur-ozkan`
@Kobzol Kobzol deleted the tidy-python-improvements branch January 24, 2025 21:54
etaoins added a commit to etaoins/rust that referenced this pull request Jan 30, 2025
@etaoins
Fix a typo in conventions.md
ba5386a 
Introduced in rust-lang#135950
@etaoins etaoins mentioned this pull request Jan 30, 2025
Merged
jhpratt added a commit to jhpratt/rust that referenced this pull request Jan 31, 2025
@jhpratt
Rollup merge of rust-lang#136323 - etaoins:fix-typo-in-conventions-md…
e429ada 
…, r=tgross35

Fix a typo in conventions.md

Introduced in rust-lang#135950
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 31, 2025
@rust-timer
Unrolled build for rust-lang#136323
5af8b1a 
Rollup merge of rust-lang#136323 - etaoins:fix-typo-in-conventions-md, r=tgross35

Fix a typo in conventions.md

Introduced in rust-lang#135950
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onur-ozkan onur-ozkan onur-ozkan approved these changes

Assignees

@jieyouxu jieyouxu

Labels
A-rustc-dev-guide Area: rustc-dev-guide A-tidy Area: The tidy tool S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.

CI Python formatting is confusing
7 participants
@Kobzol @rustbot @onur-ozkan @clubby789 @jieyouxu @bors @apiraino