Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AsyncFn* to core prelude #135852

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add AsyncFn* to core prelude #135852

wants to merge 1 commit into from

Conversation

lukas-code
Copy link
Member

In #132611 these got added to the std prelude only, which looks like an oversight.

r? libs-api
cc @compiler-errors

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 22, 2025
@compiler-errors
Copy link
Member

whoops :)

i think it's obvious enough that this was an oversight that i'll just r+ this now

@bors r+

@bors
Copy link
Contributor

bors commented Jan 22, 2025

📌 Commit cc19dfa has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 22, 2025
@lukas-code
Copy link
Member Author

Nominating for beta, so this can land together with async closures and the traits in the std prelude.

@rustbot label beta-nominated T-libs-api -T-libs

@rustbot rustbot added beta-nominated Nominated for backporting to the compiler in the beta channel. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 22, 2025
@lukas-code
Copy link
Member Author

@bors rollup

jieyouxu added a commit to jieyouxu/rust that referenced this pull request Jan 22, 2025
@jieyouxu
Rollup merge of rust-lang#135852 - lukas-code:asyncfn-prelude-core, r…
f2f33b8 
…=compiler-errors

Add `AsyncFn*` to `core` prelude

In rust-lang#132611 these got added to the `std` prelude only, which looks like an oversight.

r? libs-api
cc `@compiler-errors`
@jieyouxu jieyouxu mentioned this pull request Jan 22, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 22, 2025
@bors
Auto merge of rust-lang#135861 - jieyouxu:rollup-d4naa6s, r=jieyouxu
4dac61d 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#135779 (CI: free disk on linux arm runner)
 - rust-lang#135794 (Detect missing fields with default values and suggest `..`)
 - rust-lang#135814 (ci: use ghcr buildkit image)
 - rust-lang#135818 (tests: Port `translation` to rmake.rs)
 - rust-lang#135823 (make UI tests that use `--test` work on panic=abort targets)
 - rust-lang#135837 (Remove test panic from File::open)
 - rust-lang#135852 (Add `AsyncFn*` to `core` prelude)
 - rust-lang#135856 (Library: Finalize dyn compatibility renaming)

r? `@ghost`
`@rustbot` modify labels: rollup
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Jan 22, 2025
@jieyouxu
Rollup merge of rust-lang#135852 - lukas-code:asyncfn-prelude-core, r…
5d0b482 
…=compiler-errors

Add `AsyncFn*` to `core` prelude

In rust-lang#132611 these got added to the `std` prelude only, which looks like an oversight.

r? libs-api
cc ``@compiler-errors``
@jieyouxu jieyouxu mentioned this pull request Jan 22, 2025
Closed
@Amanieu
Copy link
Member

Amanieu commented Jan 22, 2025

Since the beta crater run has already been run, we want an additional crater run to check that this doesn't introduce any issues in beta before backporting it.

@bors try

@bors
Copy link
Contributor

bors commented Jan 22, 2025

🙅 Please do not try after a pull request has been r+ed. If you need to try, unapprove (r-) it first.

@compiler-errors
Copy link
Member

We can r- it for now, crater shouldn't take long.

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 22, 2025
@compiler-errors
Copy link
Member

@bors try

@compiler-errors
Copy link
Member

I'll start crater when it's done.

@bors
Copy link
Contributor

bors commented Jan 22, 2025

⌛ Trying commit cc19dfa with merge 5cafabc...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 22, 2025
@bors
Auto merge of rust-lang#135852 - lukas-code:asyncfn-prelude-core, r=<…
5cafabc 
…try>

Add `AsyncFn*` to `core` prelude

In rust-lang#132611 these got added to the `std` prelude only, which looks like an oversight.

r? libs-api
cc `@compiler-errors`
@bors
Copy link
Contributor

bors commented Jan 22, 2025

☀️ Try build successful - checks-actions
Build commit: 5cafabc (5cafabc9f16561d7796554d5d241c3068e2bd97f)

@compiler-errors
Copy link
Member

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-135852 created and queued.
🤖 Automatically detected try build 5cafabc
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 22, 2025
@craterbot
Copy link
Collaborator

🚧 Experiment pr-135852 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-135852 is completed!
📊 1 regressed and 1 fixed (571795 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
beta-nominated Nominated for backporting to the compiler in the beta channel. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lukas-code @compiler-errors @bors @Amanieu @craterbot @m-ou-se @rustbot