Update contributing docs for submodule/subtree changes #135770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-meta
|
It's probably still non-trivial for someone to even figure out that a direct directory is a subtree, but this is an improvement nevertheless. Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
Yeah, it's still difficult because there's a hybrid mix of submodules and subtrees and that list can keep changing. |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 20, 2025
…uting, r=Kobzol Update contributing docs for submodule/subtree changes Noticed in rust-lang#135337 (comment). r? `@Kobzol` (or anyone really)
This was referenced Jan 20, 2025
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 20, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#133695 (Reexport likely/unlikely in std::hint) - rust-lang#135330 (Respect --sysroot for rustc -vV and -Cpasses=list) - rust-lang#135333 (Partial progress on rust-lang#132735: Replace extern "rust-intrinsic" with #[rustc_intrinsic] across the codebase) - rust-lang#135741 (Recognise new IPv6 documentation range from IETF RFC 9637) - rust-lang#135770 (Update contributing docs for submodule/subtree changes) - rust-lang#135775 (Subtree update of `rust-analyzer`) - rust-lang#135776 (Subtree sync for rustc_codegen_cranelift) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 20, 2025
Rollup merge of rust-lang#135770 - jieyouxu:subtree-submodule-contributing, r=Kobzol Update contributing docs for submodule/subtree changes Noticed in rust-lang#135337 (comment). r? ``@Kobzol`` (or anyone really)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed in #135337 (comment).
r? @Kobzol (or anyone really)