-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New attribute parsing infrastructure #135726
base: master
Are you sure you want to change the base?
Conversation
r? @Noratrieb rustbot has assigned @Noratrieb. Use |
053b11b
to
5a3ac64
Compare
This comment has been minimized.
This comment has been minimized.
5a3ac64
to
bbdb095
Compare
This comment has been minimized.
This comment has been minimized.
r? oli-obk |
bbdb095
to
5d70659
Compare
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #135754) made this pull request unmergeable. Please resolve the merge conflicts. |
4d3437f
to
b3d6ef4
Compare
This comment has been minimized.
This comment has been minimized.
b3d6ef4
to
7319c1a
Compare
This comment has been minimized.
This comment has been minimized.
4aaff39
to
2f73b56
Compare
This comment has been minimized.
This comment has been minimized.
2f73b56
to
e8773d9
Compare
9ef7cd9
to
f427ea8
Compare
This comment has been minimized.
This comment has been minimized.
f427ea8
to
0f287c0
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
welp, apparently also broke clippy... 1s |
actually; wrong again: I already worked out this was going to break clippy in november so asked @GuillaumeGomez to help and fix it but it seems the change hasn't landed yet (rust-lang/rust-clippy#13658) |
☔ The latest upstream changes (presumably #128657) made this pull request unmergeable. Please resolve the merge conflicts. |
edd86b3
to
e56dd22
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
note: compiler compiles but librustdoc and clippy don't document find_attr! better
745dbb6
to
5d5a3fa
Compare
The job Click to see the possible cause of the failure (guessed by this bot)
|
Another step in the plan outlined in #131229
introduces infrastructure for structured parsers for attributes, as well as converting a couple of complex attributes to have such structured parsers.
This PR may prove too large to review. I left some of my own comments to guide it a little. Some general notes:
malformed repr(align(N))
#132391. I think most choices I made here are generally reasonable, but let me know if you disagree anywhere.rustc_ast_data_structures::AttributeKind
In general, a lot of the additions here are comments. I've found it very important to document new things in the 2nd commit well so other people can start using it.
Closes #132391