Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default_field_values entry to unstable book #134855

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Add default_field_values entry to unstable book #134855

merged 1 commit into from
Jan 10, 2025

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Dec 28, 2024 •
edited
Loading

@estebank estebank added the F-default_field_values `#![feature(default_field_values)]` label Dec 28, 2024
@rustbot
Copy link
Collaborator

rustbot commented Dec 28, 2024

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 28, 2024
@estebank estebank mentioned this pull request Dec 28, 2024
Open
17 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@estebank estebank force-pushed the default-field-values-unstable-docs branch from 7b7041b to 62c6631 Compare December 28, 2024 19:18
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@estebank estebank force-pushed the default-field-values-unstable-docs branch from 62c6631 to 5693f3a Compare December 30, 2024 21:08
@apiraino
Copy link
Contributor

apiraino commented Jan 8, 2025

IIUC I think this should be assigned to someone actually updating the book, right? cc @carols10cents

@estebank
Copy link
Contributor Author

estebank commented Jan 8, 2025

IIUC I think this should be assigned to someone actually updating the book, right?

@apiraino that doesn't seem to be the case. A quick search pulls up these recent PRs:

This is the unstable book, which is completely unrelated (AIUI) to The Book.

I wouldn't want to leave this PR with no assignee. @jieyouxu, I see that you reviewed at least one of the PRs above, could you take a look?

@jieyouxu
Copy link
Member

jieyouxu commented Jan 8, 2025

I could. r? jieyouxu

@jieyouxu jieyouxu added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Jan 8, 2025
@apiraino
Copy link
Contributor

apiraino commented Jan 8, 2025

This is the unstable book, which is completely unrelated (AIUI) to The Book.

Oh I'm sorry, this is the key info I was missing, it was probably assigned to him due to this. Anyway, no need to assign to someone else :) the PR could have being reassigned to Guillaume (currently on leave).

thanks for clarifying and sorry for the confusion

jieyouxu
jieyouxu approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one question, but r=me with or without the nit.

src/doc/unstable-book/src/language-features/default-field-values.md
Comment on lines +3 to +5
The tracking issue for this feature is: [#132162]

[#132162]: https://github.com/rust-lang/rust/issues/132162
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: should we also link the RFC directly here to save a layer of indirection?

@jieyouxu jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Jan 8, 2025

Oh I'm sorry, this is the key info I was missing, it was probably assigned to him due to this. Anyway, no need to assign to someone else :) the PR could have being reassigned to Guillaume (currently on leave).

@apiraino I believe that usually the team that the feature's impl is primarily concerned with will review the feature's unstable book PRs. In this case, compiler.

@estebank estebank force-pushed the default-field-values-unstable-docs branch from 5693f3a to 13e8876 Compare January 9, 2025 21:51
@estebank
Copy link
Contributor Author

estebank commented Jan 9, 2025

@bors r=jieyouxu

@bors
Copy link
Contributor

bors commented Jan 9, 2025

📌 Commit 13e8876 has been approved by jieyouxu

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 9, 2025

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 9, 2025
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
curl: (22) The requested URL returned error: 404
curl: (22) The requested URL returned error: 404
ERROR: failed to download llvm from ci

    HELP: There could be two reasons behind this:
        1) The host triple is not supported for `download-ci-llvm`.
        2) Old builds get deleted after a certain time.
    HELP: In either case, disable `download-ci-llvm` in your config.toml:
    [llvm]
    download-ci-llvm = false
    
Build completed unsuccessfully in 0:00:22

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jan 10, 2025
@workingjubilee
Rollup merge of rust-lang#134855 - estebank:default-field-values-unst…
3fc4e94 
…able-docs, r=jieyouxu

Add `default_field_values` entry to unstable book

Tracking issue: rust-lang#132162
RFC: https://github.com/rust-lang/rfcs/blob/master/text/3681-default-field-values.md
@workingjubilee workingjubilee mentioned this pull request Jan 10, 2025
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 10, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 10, 2025
@bors
Auto merge of rust-lang#135319 - matthiaskrgr:rollup-un5lol6, r=matth…
67951d9 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#133088 (`-Zrandomize-layout` harder. `Foo<T> != Foo<U>`)
 - rust-lang#134619 (Improve prose around `as_slice` example of IterMut)
 - rust-lang#134855 (Add `default_field_values` entry to unstable book)
 - rust-lang#134908 (Fix `ptr::from_ref` documentation example comment)
 - rust-lang#135275 (Add Pin::as_deref_mut to 1.84 relnotes)
 - rust-lang#135294 (Make `bare-fn-no-impl-fn-ptr-99875` test less dependent on path width)
 - rust-lang#135304 (Add tests cases from review of rust-lang#132289)
 - rust-lang#135308 (Make sure to walk into nested const blocks in `RegionResolutionVisitor`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5f6d7cf into rust-lang:master Jan 10, 2025
2 of 6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 10, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 10, 2025
@rust-timer
Unrolled build for rust-lang#134855
85862f7 
Rollup merge of rust-lang#134855 - estebank:default-field-values-unstable-docs, r=jieyouxu

Add `default_field_values` entry to unstable book

Tracking issue: rust-lang#132162
RFC: https://github.com/rust-lang/rfcs/blob/master/text/3681-default-field-values.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools F-default_field_values `#![feature(default_field_values)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
7 participants
@estebank @rustbot @rust-log-analyzer @apiraino @jieyouxu @bors @GuillaumeGomez