Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict #[non_exaustive] on structs with default field values #134539

Merged
merged 1 commit into from
Dec 21, 2024
Merged

Restrict #[non_exaustive] on structs with default field values #134539

merged 1 commit into from
Dec 21, 2024

Conversation

estebank
Copy link
Contributor

Do not allow users to apply #[non_exaustive] to a struct when they have also used default field values.

@rustbot
Copy link
Collaborator

rustbot commented Dec 20, 2024

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 20, 2024
@estebank estebank added F-default_field_values `#![feature(default_field_values)]` T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2024
@estebank estebank mentioned this pull request Dec 20, 2024
Open
17 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2024
@estebank
Restrict #[non_exaustive] on structs with default field values
b3cc9b9 
Do not allow users to apply `#[non_exaustive]` to a struct when they have also used default field values.
@estebank estebank force-pushed the restrict-non_exhaustive branch from 6b57145 to b3cc9b9 Compare December 20, 2024 17:19
jieyouxu
jieyouxu approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, you can r=me after PR CI is green.

@estebank
Copy link
Contributor Author

@bors r=jieyouxu

@bors
Copy link
Contributor

bors commented Dec 20, 2024

📌 Commit b3cc9b9 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 20, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 21, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 21, 2024
@bors
Auto merge of rust-lang#134590 - matthiaskrgr:rollup-8lz2s62, r=matth…
13170cd 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#123604 (Abstract `ProcThreadAttributeList` into its own struct)
 - rust-lang#128780 (Add `--doctest-compilation-args` option to add compilation flags to doctest compilation)
 - rust-lang#133782 (Precedence improvements: closures and jumps)
 - rust-lang#134509 (Arbitrary self types v2: niche deshadowing test)
 - rust-lang#134524 (Arbitrary self types v2: no deshadow pre feature.)
 - rust-lang#134539 (Restrict `#[non_exaustive]` on structs with default field values)
 - rust-lang#134586 (Also lint on option of function pointer comparisons)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fea6c4e into rust-lang:master Dec 21, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 21, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 21, 2024
@rust-timer
Unrolled build for rust-lang#134539
5456cdd 
Rollup merge of rust-lang#134539 - estebank:restrict-non_exhaustive, r=jieyouxu

Restrict `#[non_exaustive]` on structs with default field values

Do not allow users to apply `#[non_exaustive]` to a struct when they have also used default field values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
F-default_field_values `#![feature(default_field_values)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.
5 participants
@estebank @rustbot @rust-log-analyzer @bors @jieyouxu