-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cdb annotations for some debuginfo tests with cdb 10.0.26100.2161
#133115
Conversation
rustbot has assigned @Mark-Simulacrum. Use |
@bors try |
Update cdb annotations for some debuginfo tests with cdb `10.0.26100.2161` GitHub CI runners [recently updated to Windows Server 2022 (20241113)](https://github.com/actions/runner-images/releases/tag/win22%2F20241113.3) which included Windows Software Development Kit version `10.1.26100.1742`, which transitively shipped a `cdb` version `10.0.26100.2161`. This changed some cdb output, causing 3 debuginfo tests to fail: ``` tests\debuginfo\numeric-types.rs tests\debuginfo\range-types.rs tests\debuginfo\unit-type.rs ``` I reblessed these 3 tests locally with a matching `cdb` version. However, I am not by any means a cdb expert nor debuginfo expert, I just reblessed the tests to match whatever the new cdb version produces to unblock the tree. try-job: x86_64-msvc
// cdb-only | ||
//@ min-cdb-version: 10.0.18317.1001 | ||
//@ only-cdb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remark: // cdb-only
had no effect, but this test only contained cdb
so this really doesn't change anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me if try comes back green
Looks like they passed.
|
☀️ Try build successful - checks-actions |
@bors r+ |
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
@bors p=101 rollup=never |
Update cdb annotations for some debuginfo tests with cdb `10.0.26100.2161` GitHub CI runners [recently updated to Windows Server 2022 (20241113)](https://github.com/actions/runner-images/releases/tag/win22%2F20241113.3) which included Windows Software Development Kit version `10.1.26100.1742`, which transitively shipped a `cdb` version `10.0.26100.2161`. This changed some cdb output, causing 3 debuginfo tests to fail (see rust-lang#133107, https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/msvc.20update.20causing.20debuginfo.20failures): ``` tests\debuginfo\numeric-types.rs tests\debuginfo\range-types.rs tests\debuginfo\unit-type.rs ``` I updated cdb annotations for these 3 tests locally with a matching `cdb` version. However, I am not by any means a cdb expert nor debuginfo expert, I just reblessed the tests to match whatever the new cdb version produces to unblock the tree. It is certainly possible that debuginfo improved/regressed/both with the newer cdb version. try-job: x86_64-msvc
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
Genuine failure
|
Of course, |
This is to unblock the tree, a proper fix will need to be investigated. I think the debuginfo test suite supports revisions, however debugger directives do not respect such revisions, which is problematic. It's that 32-bit and 64-bit msvc of course have different integer widths for `isize` and `usize`, meaning their underlying integer is different and thus printed differently.
I'm going to mark this integer debuginfo test as |
Nominating because such environmental changes will probably affect beta and the 1.83 release too. @rustbot label beta-nominated |
☀️ Test successful - checks-actions |
@bors treeclosed- |
Debuginfo commands used to support When I separated the debuginfo command parser from the compiletest directive parser in 1467dee, I didn't include revision support because it wasn't used by any tests that existed at the time. |
Finished benchmarking commit (f2a3542): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (primary 4.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 788.11s -> 788.713s (0.08%) |
[beta] backports - Enforce that raw lifetimes must be valid raw identifiers rust-lang#132363 - Update cdb annotations for some debuginfo tests with cdb `10.0.26100.2161` rust-lang#133115 r? cuviper
GitHub CI runners recently updated to Windows Server 2022 (20241113) which included Windows Software Development Kit version
10.1.26100.1742
, which transitively shipped acdb
version10.0.26100.2161
.This changed some cdb output, causing 3 debuginfo tests to fail (see #133107, https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/msvc.20update.20causing.20debuginfo.20failures):
I updated cdb annotations for these 3 tests locally with a matching
cdb
version. However, I am not by any means a cdb expert nor debuginfo expert, I just reblessed the tests to match whatever the new cdb version produces to unblock the tree. It is certainly possible that debuginfo improved/regressed/both with the newer cdb version.try-job: x86_64-msvc