Clippy subtree update

[flip1995]

r? @Manishearth

[workingjubilee]

Need mingw-check to pass:

  error: function `validate_diag` is never used
    --> src/tools/clippy/clippy_utils/src/diagnostics.rs:41:4
     |
  41 | fn validate_diag(diag: &Diag<'_, impl EmissionGuarantee>) {
     |    ^^^^^^^^^^^^^
     |
     = note: `-D dead-code` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(dead_code)]`

[flip1995]

Looks like we never build Clippy in release mode in the Clippy repo.

Should be good now.

[workingjubilee]

@bors r=Manishearth

[bors]

📌 Commit 0aafd65 has been approved by Manishearth

It is now in the queue for this repository.

[bors]

⌛ Testing commit 0aafd65 with merge 59cec72...

[bors]

☀️ Test successful - checks-actions
Approved by: Manishearth
Pushing 59cec72 to master...

[rust-timer]

Finished benchmarking commit (59cec72): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

• If the regression was expected or you think it can be justified,
  please write a comment with sufficient written justification, and add
  @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
• If you think that you know of a way to resolve the regression, try to create
  a new PR with a fix for the regression.
• If you do not understand the regression or you think that it is just noise,
  you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
  were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.4%, 0.4%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[0.4%, 0.4%]	1

Max RSS (memory usage)

Results (secondary -1.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.4%	[-1.5%, -1.3%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary 2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.6%	[3.3%, 3.9%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 780.103s -> 779.98s (-0.02%)
Artifact size: 335.34 MiB -> 335.38 MiB (0.01%)

[lqd]

This doesn't change the compiler, and nalgebra is being noisy.

@rustbot label: +perf-regression-triaged

[flip1995]

@jdonszelmann this includes the Clippy attribute changes, you wanted.

[jdonszelmann]

Amazing ,thanks so much!