make shootout-k-nucleotide.rs pass official test #13206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, my fault, didn't test on empty input. Fixed in the branch. |
|
Maybe these shootout benchmarks should get some |
bors
added a commit
that referenced
this pull request
Mar 30, 2014
Correct printing (sort, new lines), reading on stdin.
|
@huonw pros: more robust, good rust example, cons: bigger code in the shootout stats. I personally like the idea, I'll try to test thinks in my future shootout PR. |
|
As said in #10393, some bench block on android. Looking at the tests, it seems to be because reading on stdin on a normal |
Correct printing (sort, new lines), reading on stdin, s/i32/uint/, ignore-android because it reads stdin
|
@cmr |
bors
added a commit
that referenced
this pull request
Mar 31, 2014
…crichton Correct printing (sort, new lines), reading on stdin.
tamird
added a commit
to tamird/rust
that referenced
this pull request
Apr 22, 2015
tamird
added a commit
to tamird/rust
that referenced
this pull request
Apr 22, 2015
tamird
added a commit
to tamird/rust
that referenced
this pull request
Apr 22, 2015
tamird
added a commit
to tamird/rust
that referenced
this pull request
Apr 22, 2015
tamird
added a commit
to tamird/rust
that referenced
this pull request
Apr 23, 2015
tamird
added a commit
to tamird/rust
that referenced
this pull request
Apr 24, 2015
tamird
added a commit
to tamird/rust
that referenced
this pull request
Apr 25, 2015
tamird
added a commit
to tamird/rust
that referenced
this pull request
Apr 29, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct printing (sort, new lines), reading on stdin.