Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that def id <=> lang item map is bidirectional #130468

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Make sure that def id <=> lang item map is bidirectional #130468

merged 1 commit into from
Sep 18, 2024

Conversation

compiler-errors
Copy link
Member

Self-explanatory from assertion. Just makes sure of an invariant that I forgot to enforce when I added LanguageItems::from_def_id.

@rustbot
Copy link
Collaborator

rustbot commented Sep 17, 2024

r? @Nadrieril

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 17, 2024
@Nadrieril
Copy link
Member

👍

@bors r+

@bors
Copy link
Contributor

bors commented Sep 18, 2024

📌 Commit d9624ed has been approved by Nadrieril

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 18, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 18, 2024
@bors
Auto merge of rust-lang#130500 - matthiaskrgr:rollup-lfx3bb4, r=matth…
82d17a4 
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#130466 (tests: add repr/transparent test for aarch64)
 - rust-lang#130468 (Make sure that def id <=> lang item map is bidirectional)
 - rust-lang#130499 (Add myself to the libs review rotation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7e67d90 into rust-lang:master Sep 18, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 18, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 18, 2024
@rust-timer
Unrolled build for rust-lang#130468
9026364 
Rollup merge of rust-lang#130468 - compiler-errors:bidi, r=Nadrieril

Make sure that def id <=> lang item map is bidirectional

Self-explanatory from assertion. Just makes sure of an invariant that I forgot to enforce when I added `LanguageItems::from_def_id`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Urgau Urgau Urgau left review comments

Assignees

@Nadrieril Nadrieril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.
5 participants
@compiler-errors @rustbot @Nadrieril @bors @Urgau