Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #129628

Closed
wants to merge 35 commits into from
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
7643ea5
create a new section on pointer to reference conversion
lolbinarycat Jul 24, 2024
1073f97
remove duplicate explanations of the ptr to ref conversion rules
lolbinarycat Jul 24, 2024
3877a7b
clarify interactions with MaybeUninit and UnsafeCell
lolbinarycat Jul 25, 2024
1944894
Add `warn(unreachable_pub)` to several crates.
nnethercote Jun 11, 2024
f839309
Add `warn(unreachable_pub)` to `rustc_arena`.
nnethercote Jun 11, 2024
ea014b4
Add `warn(unreachable_pub)` to `rustc_ast_lowering`.
nnethercote Jun 11, 2024
a6b2880
Add `warn(unreachable_pub)` to `rustc_ast_passes`.
nnethercote Jul 6, 2024
f2fc87d
Add `warn(unreachable_pub)` to `rustc_ast_pretty`.
nnethercote Jul 6, 2024
6614165
Add `warn(unreachable_pub)` to `rustc_attr`.
nnethercote Jul 6, 2024
cb3f435
Don't add `warn(unreachable_pub)` to `rustc_baked_icu`.
nnethercote Jul 6, 2024
0685c97
Add `warn(unreachable_pub)` to `rustc_borrowck`.
nnethercote Jul 6, 2024
0544d3a
Add `warn(unreachable_pub)` to `rustc_builtin_macros`.
nnethercote Jul 6, 2024
6162743
Add `warn(unreachable_pub)` to `rustc_codegen_llvm`.
nnethercote Jul 6, 2024
cc84442
Add `warn(unreachable_pub)` to `rustc_codegen_ssa`.
nnethercote Jul 6, 2024
988bc1c
fix typos in new pointer conversion docs
lolbinarycat Aug 22, 2024
2540070
document & impl the transmutation modeled by `BikeshedIntrinsicFrom`
jswrenn Aug 12, 2024
b581fed
Generate missing source link on impl associated types
GuillaumeGomez Aug 25, 2024
ca6be74
Add regression test for impl associated types source link
GuillaumeGomez Aug 25, 2024
6cd9bcd
Improve `isqrt` tests and add benchmarks
ChaiTRex Aug 26, 2024
e1d0630
Speed up `checked_isqrt` and `isqrt` methods
ChaiTRex Aug 26, 2024
00c435d
Do not ICE on non-ADT rcvr type when looking for crate version collision
estebank Aug 18, 2024
4a088d9
Remove crashes from type_of on resolution that doesn't have a type_of
compiler-errors Aug 26, 2024
b11e0a8
Apply suggestions from code review
cuviper Aug 26, 2024
4e15554
Remove a couple of unused feature enables
bjorn3 Aug 26, 2024
b4d3fa4
Remove ParamMode::ExplicitNamed
compiler-errors Aug 26, 2024
2db1d2e
Rename ParenthesizedGenericArgs to GenericArgsMode
compiler-errors Aug 26, 2024
478987e
Rollup merge of #126013 - nnethercote:unreachable_pub, r=Urgau
matthiaskrgr Aug 26, 2024
71f406c
Rollup merge of #128157 - lolbinarycat:unify-ptr-ref-docs, r=cuviper
matthiaskrgr Aug 26, 2024
7e1143b
Rollup merge of #128166 - ChaiTRex:isqrt, r=tgross35
matthiaskrgr Aug 26, 2024
77fb9a3
Rollup merge of #129032 - jswrenn:transmute-method, r=compiler-errors
matthiaskrgr Aug 26, 2024
28c4516
Rollup merge of #129250 - estebank:issue-129205, r=compiler-errors
matthiaskrgr Aug 26, 2024
ca124b5
Rollup merge of #129560 - GuillaumeGomez:impl-assoc-type-source-link,…
matthiaskrgr Aug 26, 2024
ead5741
Rollup merge of #129622 - bjorn3:less_unstable, r=lqd
matthiaskrgr Aug 26, 2024
3631904
Rollup merge of #129625 - compiler-errors:generic-args-mode, r=fmease
matthiaskrgr Aug 26, 2024
ed88bdd
Rollup merge of #129626 - compiler-errors:explicit-named, r=fmease
matthiaskrgr Aug 26, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions compiler/rustc_ast_lowering/src/item.rs
Original file line number Diff line number Diff line change
Expand Up @@ -764,18 +764,7 @@ impl<'hir> LoweringContext<'_, 'hir> {
&mut self,
(index, f): (usize, &FieldDef),
) -> hir::FieldDef<'hir> {
let ty = if let TyKind::Path(qself, path) = &f.ty.kind {
let t = self.lower_path_ty(
&f.ty,
qself,
path,
ParamMode::ExplicitNamed, // no `'_` in declarations (Issue #61124)
ImplTraitContext::Disallowed(ImplTraitPosition::FieldTy),
);
self.arena.alloc(t)
} else {
self.lower_ty(&f.ty, ImplTraitContext::Disallowed(ImplTraitPosition::FieldTy))
};
let ty = self.lower_ty(&f.ty, ImplTraitContext::Disallowed(ImplTraitPosition::FieldTy));
let hir_id = self.lower_node_id(f.id);
self.lower_attrs(hir_id, &f.attrs);
hir::FieldDef {
Expand Down
2 changes: 0 additions & 2 deletions compiler/rustc_ast_lowering/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -482,8 +482,6 @@ pub fn lower_to_hir(tcx: TyCtxt<'_>, (): ()) -> hir::Crate<'_> {
enum ParamMode {
/// Any path in a type context.
Explicit,
/// Path in a type definition, where the anonymous lifetime `'_` is not allowed.
ExplicitNamed,
/// The `module::Type` in `module::Type::method` in an expression.
Optional,
}
Expand Down
Loading