[rustdoc] Remove duplicated options in doctests compilation flags saved in argument file #129266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
I'd rather try to figure out why the duplicates are being added in the first place, if it's a problem. I'd also like to know if there's enough of a problem to justify the risk associated with this change. |
|
Oh. That's quite a bit misunderstanding on my end. I'll rewrite this PR with a |
|
But that's still not right, because of this: $ cat > test.rs
pub fn MyFunc() {}
^D
$ rustc --crate-type=lib test.rs
warning: function `MyFunc` should have a snake case name
--> test.rs:1:8
|
1 | pub fn MyFunc() {}
| ^^^^^^ help: convert the identifier to snake case: `my_func`
|
= note: `#[warn(non_snake_case)]` on by default
warning: 1 warning emitted
$ rustc --crate-type=lib -Anonstandard_style test.rs
$ rustc --crate-type=lib -Anonstandard_style -Wnonstandard_style test.rs
warning: function `MyFunc` should have a snake case name
--> test.rs:1:8
|
1 | pub fn MyFunc() {}
| ^^^^^^ help: convert the identifier to snake case: `my_func`
|
= note: `-W non-snake-case` implied by `-W nonstandard-style`
= help: to override `-W nonstandard-style` add `#[allow(non_snake_case)]`
warning: 1 warning emitted
$ rustc --crate-type=lib -Anonstandard_style -Wnonstandard_style -Anonstandard_style test.rs |
|
I wonder if it isn't only linked to In comparison for |
|
Closing in favor of #129278. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I took a look about what was stored in this file recently, I realized that a lot of options were duplicated. Using a set will prevent that. I used a
BTreeSetto keep the original flags order just in case.r? @notriddle