Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x86 target features #126599

Closed
wants to merge 2 commits into from
Closed

Add x86 target features #126599

wants to merge 2 commits into from

Conversation

sayantn
Copy link
Contributor

@sayantn sayantn commented Jun 17, 2024

Added missing x86 target-features

  • SHA512
  • SM3
  • SM4
  • AMX (all 5)
  • AVX-VNNI (all 3)
  • AVX-IFMA
  • AVX-NE-CONVERT

See stdarch PR 1585

@rustbot
Copy link
Collaborator

rustbot commented Jun 17, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @compiler-errors (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 17, 2024
@rust-log-analyzer
Copy link
Collaborator

The job mingw-check-tidy failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Getting action download info
Download action repository 'msys2/[email protected]' (SHA:cc11e9188b693c2b100158c3322424c4cc1dadea)
Download action repository 'actions/checkout@v4' (SHA:692973e3d937129bcbf40652eb9f2f61becf3332)
Download action repository 'actions/upload-artifact@v4' (SHA:65462800fd760344b1a7b4382951275a0abb4808)
Complete job name: PR - mingw-check-tidy
git config --global core.autocrlf false
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
COPY scripts/sccache.sh /scripts/
RUN sh /scripts/sccache.sh

COPY host-x86_64/mingw-check/reuse-requirements.txt /tmp/
RUN pip3 install --no-deps --no-cache-dir --require-hashes -r /tmp/reuse-requirements.txt \
    && pip3 install virtualenv
COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/

# NOTE: intentionally uses python2 for x.py so we can test it still works.
# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
           --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
#    pip-compile --allow-unsafe --generate-hashes reuse-requirements.in
---

#12 [5/8] COPY host-x86_64/mingw-check/reuse-requirements.txt /tmp/
#12 DONE 0.0s

#13 [6/8] RUN pip3 install --no-deps --no-cache-dir --require-hashes -r /tmp/reuse-requirements.txt     && pip3 install virtualenv
#13 0.446   Downloading binaryornot-0.4.4-py2.py3-none-any.whl (9.0 kB)
#13 0.464 Collecting boolean-py==4.0
#13 0.471   Downloading boolean.py-4.0-py3-none-any.whl (25 kB)
#13 0.489 Collecting chardet==5.1.0
---
#13 3.728 Building wheels for collected packages: reuse
#13 3.729   Building wheel for reuse (pyproject.toml): started
#13 4.077   Building wheel for reuse (pyproject.toml): finished with status 'done'
#13 4.078   Created wheel for reuse: filename=reuse-1.1.0-cp310-cp310-manylinux_2_35_x86_64.whl size=181117 sha256=f5f58750481f69515c2c0d1d503daf565e2565c370d07fc6aeb95fe3498b4269
#13 4.078   Stored in directory: /tmp/pip-ephem-wheel-cache-zz624xnt/wheels/c2/3c/b9/1120c2ab4bd82694f7e6f0537dc5b9a085c13e2c69a8d0c76d
#13 4.081 Installing collected packages: boolean-py, binaryornot, setuptools, reuse, python-debian, markupsafe, license-expression, jinja2, chardet
#13 4.105   Attempting uninstall: setuptools
#13 4.105     Found existing installation: setuptools 59.6.0
#13 4.107     Not uninstalling setuptools at /usr/lib/python3/dist-packages, outside environment /usr
#13 4.107     Not uninstalling setuptools at /usr/lib/python3/dist-packages, outside environment /usr
#13 4.107     Can't uninstall 'setuptools'. No files were found to uninstall.
#13 4.804 Successfully installed binaryornot-0.4.4 boolean-py-4.0 chardet-5.1.0 jinja2-3.1.2 license-expression-30.0.0 markupsafe-2.1.1 python-debian-0.1.49 reuse-1.1.0 setuptools-66.0.0
#13 4.804 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#13 5.337 Collecting virtualenv
#13 5.385   Downloading virtualenv-20.26.2-py3-none-any.whl (3.9 MB)
#13 5.567      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.9/3.9 MB 21.8 MB/s eta 0:00:00
#13 5.608 Collecting distlib<1,>=0.3.7
#13 5.616   Downloading distlib-0.3.8-py2.py3-none-any.whl (468 kB)
#13 5.628      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 468.9/468.9 KB 47.9 MB/s eta 0:00:00
#13 5.662 Collecting platformdirs<5,>=3.9.1
#13 5.670   Downloading platformdirs-4.2.2-py3-none-any.whl (18 kB)
#13 5.706 Collecting filelock<4,>=3.12.2
#13 5.714   Downloading filelock-3.15.1-py3-none-any.whl (15 kB)
#13 5.804 Installing collected packages: distlib, platformdirs, filelock, virtualenv
#13 5.972 Successfully installed distlib-0.3.8 filelock-3.15.1 platformdirs-4.2.2 virtualenv-20.26.2
#13 DONE 6.1s

#14 [7/8] COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
#14 DONE 0.0s
---
DirectMap4k:      192448 kB
DirectMap2M:     6098944 kB
DirectMap1G:    12582912 kB
##[endgroup]
Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test            --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
+ TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
    Finished `dev` profile [unoptimized] target(s) in 0.04s
##[endgroup]
downloading https://ci-artifacts.rust-lang.org/rustc-builds-alt/9b584a6f6fa7e1ab7c65444a7902578c1786ce18/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz
extracting /checkout/obj/build/cache/llvm-9b584a6f6fa7e1ab7c65444a7902578c1786ce18-true/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz to /checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm
---
   Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
    Finished `release` profile [optimized] target(s) in 26.22s
##[endgroup]
fmt check
##[error]Diff in /checkout/compiler/rustc_target/src/target_features.rs at line 216:
     ("avxifma", Unstable(sym::avx512_target_feature)),
     ("avxneconvert", Unstable(sym::avx512_target_feature)),
     ("avxvnni", Unstable(sym::avx512_target_feature)),
-    ("avxvnniint16",  Unstable(sym::avx512_target_feature)),
-    ("avxvnniint8",  Unstable(sym::avx512_target_feature)),
+    ("avxvnniint16", Unstable(sym::avx512_target_feature)),
+    ("avxvnniint8", Unstable(sym::avx512_target_feature)),
     ("bmi1", Stable),
     ("bmi2", Stable),
     ("cmpxchg16b", Stable),
fmt error: Running `"/checkout/obj/build/x86_64-unknown-linux-gnu/rustfmt/bin/rustfmt" "--config-path" "/checkout" "--edition" "2021" "--unstable-features" "--skip-children" "--check" "/checkout/compiler/rustc_target/src/target_features.rs" "/checkout/compiler/rustc_target/src/tests.rs" "/checkout/compiler/rustc_target/src/asm/csky.rs" "/checkout/compiler/rustc_target/src/asm/s390x.rs" "/checkout/compiler/rustc_target/src/asm/mips.rs" "/checkout/compiler/rustc_target/src/asm/mod.rs" "/checkout/compiler/rustc_target/src/asm/arm.rs" "/checkout/compiler/rustc_target/src/asm/spirv.rs" "/checkout/compiler/rustc_target/src/asm/powerpc.rs" "/checkout/compiler/rustc_target/src/asm/nvptx.rs" "/checkout/compiler/rustc_target/src/asm/riscv.rs" "/checkout/compiler/rustc_target/src/asm/loongarch.rs" "/checkout/compiler/rustc_target/src/asm/x86.rs" "/checkout/compiler/rustc_target/src/asm/msp430.rs" "/checkout/compiler/rustc_target/src/asm/aarch64.rs" "/checkout/compiler/rustc_target/src/asm/m68k.rs" "/checkout/compiler/rustc_target/src/asm/avr.rs" "/checkout/compiler/rustc_target/src/asm/bpf.rs" "/checkout/compiler/rustc_target/src/asm/wasm.rs" "/checkout/compiler/rustc_target/src/asm/hexagon.rs" "/checkout/compiler/rustc_target/src/json.rs" "/checkout/compiler/rustc_target/src/spec/crt_objects.rs" "/checkout/compiler/rustc_target/src/spec/mod.rs" "/checkout/compiler/rustc_target/src/spec/tests/tests_impl.rs" "/checkout/compiler/rustc_target/src/spec/base/linux_musl.rs" "/checkout/compiler/rustc_target/src/spec/base/windows_gnullvm.rs" "/checkout/compiler/rustc_target/src/spec/base/freebsd.rs" "/checkout/compiler/rustc_target/src/spec/base/msvc.rs" "/checkout/compiler/rustc_target/src/spec/base/windows_gnu.rs" "/checkout/compiler/rustc_target/src/spec/base/haiku.rs" "/checkout/compiler/rustc_target/src/spec/base/dragonfly.rs" "/checkout/compiler/rustc_target/src/spec/base/solaris.rs" "/checkout/compiler/rustc_target/src/spec/base/android.rs" "/checkout/compiler/rustc_target/src/spec/base/xtensa.rs" "/checkout/compiler/rustc_target/src/spec/base/linux_uclibc.rs" "/checkout/compiler/rustc_target/src/spec/base/hermit.rs" "/checkout/compiler/rustc_target/src/spec/base/windows_uwp_msvc.rs" "/checkout/compiler/rustc_target/src/spec/base/netbsd.rs" "/checkout/compiler/rustc_target/src/spec/base/windows_msvc.rs" "/checkout/compiler/rustc_target/src/spec/base/mod.rs" "/checkout/compiler/rustc_target/src/spec/base/apple/tests.rs" "/checkout/compiler/rustc_target/src/spec/base/apple/mod.rs" "/checkout/compiler/rustc_target/src/spec/base/solid.rs" "/checkout/compiler/rustc_target/src/spec/base/vxworks.rs" "/checkout/compiler/rustc_target/src/spec/base/hurd.rs" "/checkout/compiler/rustc_target/src/spec/base/aix.rs" "/checkout/compiler/rustc_target/src/spec/base/redox.rs" "/checkout/compiler/rustc_target/src/spec/base/windows_uwp_gnu.rs" "/checkout/compiler/rustc_target/src/spec/base/uefi_msvc.rs" "/checkout/compiler/rustc_target/src/spec/base/linux.rs" "/checkout/compiler/rustc_target/src/spec/base/illumos.rs" "/checkout/compiler/rustc_target/src/spec/base/avr_gnu.rs" "/checkout/compiler/rustc_target/src/spec/base/fuchsia.rs" "/checkout/compiler/rustc_target/src/spec/base/hurd_gnu.rs" "/checkout/compiler/rustc_target/src/spec/base/bpf.rs" "/checkout/compiler/rustc_target/src/spec/base/wasm.rs" "/checkout/compiler/rustc_target/src/spec/base/unikraft_linux_musl.rs" "/checkout/compiler/rustc_target/src/spec/base/l4re.rs" "/checkout/compiler/rustc_target/src/spec/base/nto_qnx.rs" "/checkout/compiler/rustc_target/src/spec/base/thumb.rs" "/checkout/compiler/rustc_target/src/spec/base/linux_gnu.rs" "/checkout/compiler/rustc_target/src/spec/base/openbsd.rs" "/checkout/compiler/rustc_target/src/spec/base/linux_ohos.rs" "/checkout/compiler/rustc_interface/src/lib.rs"` failed.
If you're running `tidy`, try again with `--bless`. Or, if you just want to format code, run `./x.py fmt` instead.
  local time: Mon Jun 17 15:38:09 UTC 2024
  network time: Mon, 17 Jun 2024 15:38:09 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

@sayantn sayantn closed this Jun 17, 2024
@sayantn sayantn deleted the veorq branch June 17, 2024 15:45
@workingjubilee workingjubilee added the O-x86_64 Target: x86-64 processors (like x86_64-*) label Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-merge-commits PR has merge commits, merge with caution. O-x86_64 Target: x86-64 processors (like x86_64-*) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants