-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement RFC 3624 supertrait_item_shadowing
(v2)
#125782
base: master
Are you sure you want to change the base?
Implement RFC 3624 supertrait_item_shadowing
(v2)
#125782
Conversation
supertrait_item_shadowing
supertrait_item_shadowing
(v2)
☔ The latest upstream changes (presumably #125443) made this pull request unmergeable. Please resolve the merge conflicts. |
e95db1b
to
8665a82
Compare
OK, this is ready pending RFC approval. |
This comment has been minimized.
This comment has been minimized.
8665a82
to
d03f75d
Compare
The RFC is now in FCP, so this could probably get reviewed preliminarily but should probably not land until the RFC is merged. r? compiler |
☔ The latest upstream changes (presumably #124895) made this pull request unmergeable. Please resolve the merge conflicts. |
d03f75d
to
ffbb443
Compare
ffbb443
to
1ab7845
Compare
This comment has been minimized.
This comment has been minimized.
1ab7845
to
e59cf24
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there’s a few missing words in the lint comments, and maybe some places that say “method” should say “item”?
e59cf24
to
8409aaa
Compare
@rustbot ready This PR is ready for review since the corresponding RFC has landed. |
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
…owing, r=<try> Implement RFC 3624 `supertrait_item_shadowing` (v2) Implements RFC 3624 and the associated lint in the RFC. Implements: * Shadowing algorithm * Lint for call-site shadowing (allow by default, gated) * Lint for definition-site shadowing (allow by default, gated) Tracking: - rust-lang#89151 cc `@Amanieu` and rust-lang/rfcs#3624 and rust-lang#89151
The job Click to see the possible cause of the failure (guessed by this bot)
|
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (2f0cace): comparison URL. Overall result: ❌✅ regressions and improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -1.5%, secondary 3.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary 3.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 770.579s -> 771.216s (0.08%) |
Implements RFC 3624 and the associated lint in the RFC.
Implements:
Tracking:
cc @Amanieu and rust-lang/rfcs#3624 and #89151