Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use compiletest directives instead of manually checking TARGET / tools #123146

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Use compiletest directives instead of manually checking TARGET / tools #123146

merged 4 commits into from
Mar 28, 2024

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Mar 27, 2024 •
edited
Loading

Changes:

  • Accept ignore-wasm32-wasip1 and needs-wasmtime directives.
  • Add support for needing wasmtime as a runner.
  • Update wasm/compiler_builtin tests to use compiletest directives over manual checks.

@rustbot
Copy link
Collaborator

rustbot commented Mar 27, 2024

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 27, 2024
@jieyouxu jieyouxu force-pushed the use-compiletest-directives branch from 658841a to 9762d66 Compare March 28, 2024 00:32
@jieyouxu jieyouxu removed the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Mar 28, 2024
@jieyouxu jieyouxu marked this pull request as ready for review March 28, 2024 00:33
@clubby789
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Mar 28, 2024

📌 Commit 9762d66 has been approved by clubby789

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 28, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 28, 2024
@bors
Auto merge of rust-lang#123171 - matthiaskrgr:rollup-7id2r8o, r=matth…
ba52720 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#123063 (Function ABI is irrelevant for reachability)
 - rust-lang#123096 (Don't check match scrutinee of postfix match for unused parens)
 - rust-lang#123146 (Use compiletest directives instead of manually checking TARGET / tools)
 - rust-lang#123160 (remove `def_id_to_node_id` in ast lowering)
 - rust-lang#123162 (Correctly get complete intra-doc link data)
 - rust-lang#123164 (Bump Unicode printables to version 15.1, align to unicode_data)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d1630e5 into rust-lang:master Mar 28, 2024
18 of 22 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Mar 28, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 28, 2024
@rust-timer
Unrolled build for rust-lang#123146
95ea00c 
Rollup merge of rust-lang#123146 - jieyouxu:use-compiletest-directives, r=clubby789

Use compiletest directives instead of manually checking TARGET / tools

Changes:

- Accept `ignore-wasm32-wasip1` and `needs-wasmtime` directives.
- Add support for needing `wasmtime` as a runner.
- Update wasm/compiler_builtin tests to use compiletest directives over manual checks.
@jieyouxu jieyouxu deleted the use-compiletest-directives branch March 28, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@clubby789 clubby789

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jieyouxu @rustbot @clubby789 @bors