-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor makefiles to be more flexible producing binary install images #12284
Conversation
This is a slightly more generic rewrite of install.mk. Currently used for nothing, but we'll base all the binary distributables off it.
Fallout from moving doc/ to src/doc
You may want to make sure that |
I just realized this will run as root during installation from source. Think about that. |
Well, we would probably end up not having |
I want to just rewrite this in Rust. |
Why is that? Is that because of the
I would not be opposed, but if it works for now, perhaps we can keep it? |
Yes because of |
I've done testing in a number of multi-target/multi-host configs now. Think this is working. |
Oh, this still doesn't support |
|
Work toward #9876. This adds `prepare.mk`, which is simply a more heavily-parameterized `install.mk`, then uses `prepare` to implement both `install` and the windows installer (`dist`). Smoke tested on both Linux and Windows.
internal: Cleanup lifetime elision hints
Fix ICE in `upper_case_acronyms` fixes rust-lang#12284 The logic has been rewritten to avoid allocations. The old version allocated multiple vecs and strings for each identifier. The new logic allocates a single string only when the lint triggers. This also no longer lints on strings which don't start with an uppercase letter (e.g. `something_FOO`). changelog: none
Work toward #9876.
This adds
prepare.mk
, which is simply a more heavily-parameterizedinstall.mk
, then usesprepare
to implement bothinstall
and the windows installer (dist
). Smoke tested on both Linux and Windows.