Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize bootstrap_out path #122427

Merged
merged 1 commit into from
May 1, 2024
Merged

Normalize bootstrap_out path #122427

merged 1 commit into from
May 1, 2024

Conversation

psumbera
Copy link
Contributor

@psumbera psumbera commented Mar 13, 2024 •
edited by clubby789
Loading

Fixes #112785

@rustbot
Copy link
Collaborator

rustbot commented Mar 13, 2024

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 13, 2024
Kobzol
Kobzol reviewed Mar 13, 2024
View reviewed changes
@clubby789 clubby789 changed the title Normalize bootstrap_out path (Issue #112785) Normalize bootstrap_out path Mar 14, 2024
@psumbera
Copy link
Contributor Author

Is there anything blocking this? Thank you!

@clubby789
Copy link
Contributor

Sorry for the wait - this looks good to me. r=me with commits squashed (preferably remove the issue tag from the commits, since it causes spammy messages when being tested)

@psumbera psumbera force-pushed the bootstrap_out_path branch from a0a6a55 to feeb184 Compare April 29, 2024 07:03
@Dylan-DPC
Copy link
Member

@bors r=clubby789

@bors
Copy link
Contributor

bors commented May 1, 2024

📌 Commit feeb184 has been approved by clubby789

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 1, 2024
@bors
Copy link
Contributor

bors commented May 1, 2024

⌛ Testing commit feeb184 with merge 9ba3d31...

@bors
Copy link
Contributor

bors commented May 1, 2024

☀️ Test successful - checks-actions
Approved by: clubby789
Pushing 9ba3d31 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 1, 2024
@bors bors merged commit 9ba3d31 into rust-lang:master May 1, 2024
11 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 1, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9ba3d31): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672s -> 673.915s (0.28%)
Artifact size: 315.97 MiB -> 315.97 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kobzol Kobzol Kobzol left review comments

Assignees

@clubby789 clubby789

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.80.0
7 participants
@psumbera @rustbot @clubby789 @Dylan-DPC @bors @rust-timer @Kobzol