Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiletest: Replace bool with enum AuxType for clarity #122419

Closed
wants to merge 3 commits into from
Closed

compiletest: Replace bool with enum AuxType for clarity #122419

wants to merge 3 commits into from

Conversation

Enselic
Copy link
Member

@Enselic Enselic commented Mar 13, 2024 •
edited
Loading

This is part of #121573 which I am splitting up into smaller PRs for easier review.

A subsequent PR will add a AuxType::Bin enum variant.

@rustbot
Copy link
Collaborator

rustbot commented Mar 13, 2024

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 13, 2024
@Enselic Enselic mentioned this pull request Mar 13, 2024
Merged
@Enselic
Copy link
Member Author

Enselic commented Mar 17, 2024

Maybe it is easier to review this in full context after all, so I am closing this in favor of #122634.

@Enselic Enselic closed this Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Enselic @rustbot @compiler-errors