Check library crates for all tier 1 targets in PR CI #122401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @Mark-Simulacrum. Use r? to explicitly pick a reviewer |
rustbot
added
A-testsuite
This comment has been minimized.
This comment has been minimized.
ChrisDenton
force-pushed
the
check-tier1
branch
2 times, most recently
from
141281a to
c196504
Compare
ChrisDenton
changed the title
This comment has been minimized.
This comment has been minimized.
ChrisDenton
force-pushed
the
check-tier1
branch
from
c196504 to
21ab400
Compare
This comment has been minimized.
This comment has been minimized.
ChrisDenton
force-pushed
the
check-tier1
branch
from
21ab400 to
22cb6b5
Compare
This comment has been minimized.
This comment has been minimized.
ChrisDenton
force-pushed
the
check-tier1
branch
2 times, most recently
from
dc6965d to
ccca193
Compare
|
Ok, that's working now. And it only takes |
|
Cc #121519 |
RalfJung
reviewed
Mar 14, 2024
ChrisDenton
force-pushed
the
check-tier1
branch
from
ccca193 to
a52658d
Compare
Funnily enough I'd somehow completely forgotten about that issue when I first made this PR although it must have been in the back of my mind. |
RalfJung
reviewed
Mar 14, 2024
RalfJung
reviewed
Mar 14, 2024
ChrisDenton
force-pushed
the
check-tier1
branch
from
a52658d to
9d2641f
Compare
ChrisDenton
force-pushed
the
check-tier1
branch
from
9d2641f to
d5e5ef5
Compare
| # Check library crates on all tier 1 targets. | ||
| # We disable optimized compiler built-ins because that requires a C toolchain for the target. | ||
| # We also skip the x86_64-unknown-linux-gnu target as it is well-tested by other jobs. | ||
| python3 ../x.py check --stage 0 --set build.optimized-compiler-builtins=false core alloc std --target=aarch64-unknown-linux-gnu,i686-pc-windows-msvc,i686-unknown-linux-gnu,x86_64-apple-darwin,x86_64-pc-windows-gnu,x86_64-pc-windows-msvc && \ |
There was a problem hiding this comment.
I guess this isn't including libtest and proc_macro, but those seem less likely to be target-dependent...
There was a problem hiding this comment.
Yeah. I was going by what tends to fail after an r+. Which is admittedly anecdotal and prone to biasing towards where code changes more frequently. But I figured that if it comes up then it's easy enough to add additional crates.
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 16, 2024
…enton Rollup of 7 pull requests Successful merges: - rust-lang#122323 (configure.py: add flag for loongarch64 musl-root) - rust-lang#122372 (prevent notifying the same changes more than once) - rust-lang#122390 (Bump windows-bindgen to 0.55.0) - rust-lang#122401 (Check library crates for all tier 1 targets in PR CI) - rust-lang#122489 (Bump `cargo update` PR more often) - rust-lang#122583 (Use `UnsafeCell` for fast constant thread locals) - rust-lang#122590 (bootstrap: Don't name things copy that are not copies) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 16, 2024
Rollup merge of rust-lang#122401 - ChrisDenton:check-tier1, r=Mark-Simulacrum Check library crates for all tier 1 targets in PR CI Let's try checking all tier 1 targets. Shouldn't take much time. Not sure if this is the right place to put it or not but let's see if it works first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's try checking all tier 1 targets. Shouldn't take much time.
Not sure if this is the right place to put it or not but let's see if it works first.