Deglob stdlib #12074
Closed
Deglob stdlib #12074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have a hunch this just deadlocked the windows bots. Due to UDP being a lossy protocol, I don't think we can guarantee that the server can receive both packets, so just listen for one of them.
This complements `usage` by auto-generating a short one-liner summary of the options.
A weak pointer inside itself will have its destructor run when the last strong pointer to that data disappears, so we need to make sure that the Weak and Rc destructors don't duplicate work (i.e. freeing). By making the Rcs effectively take a weak pointer, we ensure that no Weak destructor will free the pointer while still ensuring that Weak pointers can't be upgraded to strong ones as the destructors run. This approach of starting weak at 1 is what libstdc++ does. Fixes #12046.
This replaces the imports from the prelude with the re-exported symbols.
|
Yet more commits brought in. They're going to revoke my Git license. One more try. |
|
@chromatic I helped another user in #11457 if it can be of help. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
…t, r=jonas-schievink Reduce priority of flyimport completions Fixes rust-lang/rust-analyzer#12068
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 25, 2024
…hile-checking-duplicate-code, r=Jarcho Make `HirEqInterExpr::eq_block` take comments into account while checking if two blocks are equal This PR: - now makes `HirEqInterExpr::eq_block` take comments into account. Identical code with varying comments will no longer be considered equal. - makes necessary adjustments to UI tests. Closes rust-lang#12044 **Lintcheck Changes** - `match_same_arms` 53 => 52 - `if_same_then_else` 3 => 0 changelog: [`if_same_then_else`]: Blocks with different comments will no longer trigger this lint. changelog: [`match_same_arms`]: Arms with different comments will no longer trigger this lint. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another attempt to address GH #12006. I've rebased against master and only two commits appear. Let's hope the Windows build works now.