Making errors lower-cased in in libsyntax and librustc #12065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome cleanup! This is the kind of attention to detail we need to make Rust really nice. |
|
I am not sure what these failed tests mean. Did I break something? |
|
Apparently I did. The latest commit should fix that. |
|
My bad, I still missed some. I hope I covered all of them this time. |
|
Looks like a rebase is needed. Could you also squash these commits while you're at it? |
|
@alexcrichton Tried to do so, they should now be just one commit. |
|
It seems that there were some I still missed. It should be all good now. |
|
Seems to need another rebase (sorry!) |
Error messages cleaned in librustc/middle Error messages cleaned in libsyntax Error messages cleaned in libsyntax more agressively Error messages cleaned in librustc more aggressively Fixed affected tests Fixed other failing tests Last failing tests fixed
|
My bad, rust is moving extra fast =). Should be better now. |
bors
added a commit
that referenced
this pull request
Feb 8, 2014
This pull request tries to fix #12050. I went after these wrong errors quite aggressively so it might be that I also changed some strings that are not actual errors. Please point those out and I will update this pull request accordingly.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 11, 2024
Add `.front()` to `get_first` lint description Fix rust-lang#12063 changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request tries to fix #12050.
I went after these wrong errors quite aggressively so it might be that I also changed some strings that are not actual errors.
Please point those out and I will update this pull request accordingly.