rustdoc: offset generic args of cross-crate trait object types when cleaning #119769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in src/librustdoc/clean/types.rs cc @camelid |
|
CI failure due to GitHub-internal issues. See https://www.githubstatus.com/. |
fmease
force-pushed
the
rustdoc-off-by-one-dyn-trait-def-gen-args
branch
from
f54f885 to
f6511b9
Compare
GuillaumeGomez
approved these changes
Jan 9, 2024
|
Nothing to say except: great work! r=me once CI pass. |
This comment has been minimized.
This comment has been minimized.
The new names are consistent with the other rustc_middle cleaning functions. Regarding the local variable `ty_args`, it's used throughout the function and personally speaking its name isn't very legible, I trip up on it.
fmease
force-pushed
the
rustdoc-off-by-one-dyn-trait-def-gen-args
branch
from
f6511b9 to
2d010bc
Compare
|
@bors r=GuillaumeGomez rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 10, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#106893 (Explain base expression for struct update syntax) - rust-lang#119769 (rustdoc: offset generic args of cross-crate trait object types when cleaning) - rust-lang#119772 (Fix an ICE that occurs after an error has already been reported) - rust-lang#119782 (rint intrinsics: caution against actually trying to check for floating-point exceptions) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 10, 2024
Rollup merge of rust-lang#119769 - fmease:rustdoc-off-by-one-dyn-trait-def-gen-args, r=GuillaumeGomez rustdoc: offset generic args of cross-crate trait object types when cleaning Fixes rust-lang#119529. This PR contains several refactorings apart from the bug fix. Best reviewed commit by commit. r? GuillaumeGomez
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119529.
This PR contains several refactorings apart from the bug fix.
Best reviewed commit by commit.
r? GuillaumeGomez