Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead codes #119337

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Remove dead codes #119337

merged 1 commit into from
Dec 27, 2023

Conversation

mu001999
Copy link
Contributor

Detected by #118257

@rustbot
Copy link
Collaborator

rustbot commented Dec 27, 2023

r? @WaffleLapkin

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 27, 2023
@rustbot
Copy link
Collaborator

rustbot commented Dec 27, 2023

Type relation code was changed

cc @compiler-errors, @lcnr

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@WaffleLapkin
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 27, 2023

📌 Commit 1052ce9 has been approved by WaffleLapkin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2023
@bors
Copy link
Contributor

bors commented Dec 27, 2023

⌛ Testing commit 1052ce9 with merge 26e688e...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 27, 2023
@bors
Auto merge of rust-lang#119337 - mu001999:dead_code/clean, r=WaffleLa…
26e688e 
…pkin

Remove dead codes

Detected by rust-lang#118257
@bors bors mentioned this pull request Dec 27, 2023
Merged
@compiler-errors
Copy link
Member

Next time please squash this into one commit

@mu001999
Copy link
Contributor Author

Earlier my github codespace died and I couldn't open it, so I used github.dev but lacked full git functionality (can only push linearly). Now coedespace works fine and I can squash this for now ;)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 27, 2023
@WaffleLapkin
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 27, 2023
@WaffleLapkin
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 27, 2023

📌 Commit 3386783 has been approved by WaffleLapkin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 27, 2023
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@matthiaskrgr matthiaskrgr mentioned this pull request Dec 27, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 27, 2023
@bors
Auto merge of rust-lang#119343 - matthiaskrgr:rollup-vkt8lst, r=matth…
df5d535 
…iaskrgr

Rollup of 2 pull requests

Successful merges:

 - rust-lang#119175 (fix: diagnostic for casting reference to slice)
 - rust-lang#119337 (Remove dead codes)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f05e16a into rust-lang:master Dec 27, 2023
11 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 27, 2023
@rust-timer
Unrolled build for rust-lang#119337
b47270f 
Rollup merge of rust-lang#119337 - mu001999:dead_code/clean, r=WaffleLapkin

Remove dead codes

Detected by rust-lang#118257
@rustbot rustbot added this to the 1.77.0 milestone Dec 27, 2023
@mu001999 mu001999 deleted the dead_code/clean branch December 27, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WaffleLapkin WaffleLapkin Awaiting requested review from WaffleLapkin

Assignees

@WaffleLapkin WaffleLapkin

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.
6 participants
@mu001999 @rustbot @rust-log-analyzer @WaffleLapkin @bors @compiler-errors