Subtree update of `rust-analyzer` #119070

lnicola · 2023-12-18T07:23:04Z

No description provided.

…vert to named struct" assist

…compiler-errors Add support for making lib features internal We have the notion of an "internal" lang feature: a feature that is never intended to be stabilized, and using which can cause ICEs and other issues without that being considered a bug. This extends that idea to lib features as well. It is an alternative to rust-lang#115623: instead of using an attribute to declare lib features internal, we simply do this based on the name. Everything ending in `_internals` or `_internal` is considered internal. Then we rename `core_intrinsics` to `core_intrinsics_internal`, which fixes rust-lang#115597.

… parses

detects redundant imports that can be eliminated. for rust-lang#117772 : In order to facilitate review and modification, split the checking code and removing redundant imports code into two PR.

Co-authored-by: Waffle Maybe <[email protected]>

…m-ra

This way, parameter hints will be found for resolution

…ints-resolution, r=Veykril Query for nearest parent block around the hint to resolve This way, parameter hints will be found for resolution and rust-lang/rust-analyzer#15522 (comment) will be fixed Hopefully that also helps with whatever else (lifetimes', etc.) hints in rust-lang/rust-analyzer#13962 > hints are resolved by querying for textDocument/inlayHint with hint's position turned into a [position-1, position+1] range (instead of the original, much wider document range). > > This might lead to issues in the future, with e.g. lifetime hints (currently there's nothing to resolve for them and it's fine) that belong to a certain position, but need to have textDocument/inlayHint query for much bigger range than their position+/-1

…apkin Use a u64 for the rmeta root position Waffle noticed this in rust-lang#117301 (comment) We've upgraded the other file offsets to u64, and this one only costs 4 bytes per file. Also the way the truncation was being done before was extremely easy to miss, I sure missed it! It's not clear to me if not having this change effectively made the other upgrades from u32 to u64 ineffective, but we can have it now. r? `@WaffleLapkin`

Replace `doc_comments_and_attrs` with `collect_attrs`, 2nd round I didn't understand why the one in the semantics is different. Please tell me if it needs special action. r? `@Veykril`

…odules, r=Mark-Simulacrum Let `reuse` look inside git submodules Changes `collect-license-metadata` and `generate-copyright` so they can now look at the git submodules. Unfortunately `reuse` chokes on the LLVM submodule - it finds the word "Copyright" or the unicode copyright symbol in all kinds of places, including UTF-8 test cases. The `reuse` tool expressly won't let you ignore folders, so we let it scan everything and then strip out the LLVM sub-folder in post. Instead, we add in a hand-curated list of copyright information gleaned by reading the LLVM codebase carefully, which is stored in `.reuse/dep5` in Debian format where `reuse` can find and use it. The `.reuse/dep5` continues to track copyright info for files in the tree that do not have SPDX metadata in them (i.e. all of them)

Subtree update of `rust-analyzer` r? `@ghost`

minor: sync from downstream

internal: Improve import asset perf a bit And bump the query limit from 40 to 100

…and non assoc items with the same name

…kril fix: Fix `import_map::search_dependencies` getting confused by assoc and non assoc items with the same name No test case as creating one is kind of tricky... Ideally the code should be restructured such that this collision wouldn't matter in the first place, its kind of a mess. Fixes rust-lang/rust-analyzer#16074 Fixes rust-lang/rust-analyzer#16080 Fixes rust-lang/rust-analyzer#15845

Publish `line-index`

Update builtin attrs from rustc Fix rust-lang#16105 r? `@lnicola` since you did this last time.

…ert_tuple_struct_to_named_struct/handle_refs_inside_macro_invocations, r=Veykril Fix incorrectly replacing references in macro invocation in "Convert to named struct" assist Fixes rust-lang#15630. Complements rust-lang#13647 (same assist but missed this one), rust-lang#14920 (inverse action assist).

minor: Add messages to some asserts for better debugging cc rust-lang/rust-analyzer#16118

Run rust-analyzer on rustc tests in metrics fix rust-lang#15947

fix: Syntax fixup now removes subtrees with fake spans Fixes rust-lang/rust-analyzer#16118

internal: Remove `ModuleId` from `TypeOwnerId` It only exists due to the IDE layer, but we can encode this temporary hack more cleanly

Fix false positive type mismatch in const reference patterns

…m-ra

rustbot · 2023-12-18T07:23:13Z

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-12-18T07:23:14Z

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

lnicola · 2023-12-18T07:23:19Z

@bors r+ p=1 subtree sync

bors · 2023-12-18T07:23:22Z

📌 Commit ebba9b3 has been approved by lnicola

It is now in the queue for this repository.

bors · 2023-12-18T10:01:38Z

⌛ Testing commit ebba9b3 with merge 37340a1...

bors · 2023-12-18T11:58:25Z

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 37340a1 to master...

rust-timer · 2023-12-18T16:00:07Z

Finished benchmarking commit (37340a1): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.5%, 1.1%]	4
Regressions ❌ (secondary)	3.4%	[1.6%, 4.5%]	4
Improvements ✅ (primary)	-2.5%	[-2.5%, -2.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[-2.5%, 1.1%]	5

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.4%, -0.4%]	1
Improvements ✅ (secondary)	-4.3%	[-4.6%, -4.1%]	3
All ❌✅ (primary)	-0.4%	[-0.4%, -0.4%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672.726s -> 674.961s (0.33%)
Artifact size: 312.44 MiB -> 312.44 MiB (0.00%)

jinohkang-theori and others added 30 commits November 14, 2023 16:01

fix: Fix incorrectly replacing references in macro invocation in "Con…

0beba7c

…vert to named struct" assist

Put copyright on a line by itself.

bf645be

also make 'core_intrinsics' internal

11a70f6

Use a u64 for the rmeta root position

5ef5e55

fix: Fix fragment parser replacing matches with dummies on incomplete…

5f95765

… parses

remove redundant imports

5285df4

detects redundant imports that can be eliminated. for rust-lang#117772 : In order to facilitate review and modification, split the checking code and removing redundant imports code into two PR.

Apply suggestions from code review

f9453e3

Co-authored-by: Waffle Maybe <[email protected]>

Merge commit '457b966b171b09a7e57acb710fbca29a4b3526f0' into sync-fro…

f532576

…m-ra

Fix typo in cfg

71d98c5

Query for nearest parent block around the hint to resolve

be6d34b

This way, parameter hints will be found for resolution

Search for parent blocks and items when resolving inlay hints

8ae42b5

Always render the path to be imported in the completion detail

18591ae

Replace doc_comments_and_attrs with collect_attrs, 2nd round

801c0ea

Auto merge of rust-lang#16094 - HKalbasi:rustc-tests-fixup, r=HKalbasi

8c3e28e

Replace `doc_comments_and_attrs` with `collect_attrs`, 2nd round I didn't understand why the one in the semantics is different. Please tell me if it needs special action. r? `@Veykril`

Auto merge of rust-lang#118817 - lnicola:sync-from-ra, r=lnicola

be035e8

Subtree update of `rust-analyzer` r? `@ghost`

Merge branch 'master' into sync-from-rust

df7b428

Fix formatting

54acf87

Merge remote-tracking branch 'upstream/master' into sync-from-rust

13d4609

Auto merge of rust-lang#16098 - lnicola:sync-from-rust, r=lnicola

e004a5d

minor: sync from downstream

Simplify and improve perf of import_assets::import_for_item

34ec665

Bump DEFAULT_QUERY_SEARCH_LIMIT from 40 to 100

1604ad1

Auto merge of rust-lang#16099 - Veykril:flyimport, r=Veykril

d4accf8

internal: Improve import asset perf a bit And bump the query limit from 40 to 100

fix: Fix import_map::search_dependencies getting confused by assoc …

ca995d7

…and non assoc items with the same name

Publish line-index

c30fd42

Auto merge of rust-lang#16102 - lnicola:publish-libs, r=lnicola

785bccb

Publish `line-index`

bors and others added 14 commits December 13, 2023 17:55

Auto merge of rust-lang#16115 - HKalbasi:rustc-tests-fixup, r=lnicola

f81bd0c

Update builtin attrs from rustc Fix rust-lang#16105 r? `@lnicola` since you did this last time.

minor: Add messages to some asserts for better debugging

070cd4e

Auto merge of rust-lang#16121 - Veykril:assert-messages, r=Veykril

35e2f13

minor: Add messages to some asserts for better debugging cc rust-lang/rust-analyzer#16118

Remove ModuleId from TypeOwnerId

9083017

Run rust-analyzer on rustc tests in metrics

7b9595a

Auto merge of rust-lang#16125 - HKalbasi:rustc-tests, r=HKalbasi

96f6608

Run rust-analyzer on rustc tests in metrics fix rust-lang#15947

fix: Syntax fixup now removes subtrees with fake spans

4c45d23

Auto merge of rust-lang#16130 - Veykril:syntax-fixup, r=Veykril

34d572e

fix: Syntax fixup now removes subtrees with fake spans Fixes rust-lang/rust-analyzer#16118

Auto merge of rust-lang#16123 - Veykril:simplify, r=Veykril

a776419

internal: Remove `ModuleId` from `TypeOwnerId` It only exists due to the IDE layer, but we can encode this temporary hack more cleanly

Fix false positive type mismatch in const reference patterns

4f72216

Use depth 1 in git clone

fa5a327

Auto merge of rust-lang#16131 - HKalbasi:rustc-tests-fixup, r=HKalbasi

21b06c1

Fix false positive type mismatch in const reference patterns

Merge commit '21b06c1beb9bb59369ffd652f5d617bcf6952e05' into sync-fro…

ebba9b3

…m-ra

rustbot assigned Mark-Simulacrum Dec 18, 2023

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 18, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 18, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 18, 2023

bors merged commit 37340a1 into rust-lang:master Dec 18, 2023
11 checks passed

rustbot added this to the 1.76.0 milestone Dec 18, 2023

lnicola deleted the sync-from-ra branch December 18, 2023 12:00

bors mentioned this pull request Dec 18, 2023

Add rustc_intrinsic_const_vector_arg attribute to allow vectors to be passed as constants #118980

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Subtree update of `rust-analyzer` #119070

Subtree update of `rust-analyzer` #119070

lnicola commented Dec 18, 2023

rustbot commented Dec 18, 2023

rustbot commented Dec 18, 2023

lnicola commented Dec 18, 2023

bors commented Dec 18, 2023

bors commented Dec 18, 2023

bors commented Dec 18, 2023

rust-timer commented Dec 18, 2023

Subtree update of rust-analyzer #119070

Subtree update of rust-analyzer #119070

Conversation

lnicola commented Dec 18, 2023

rustbot commented Dec 18, 2023

rustbot commented Dec 18, 2023

lnicola commented Dec 18, 2023

bors commented Dec 18, 2023

bors commented Dec 18, 2023

bors commented Dec 18, 2023

rust-timer commented Dec 18, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Subtree update of `rust-analyzer` #119070

Subtree update of `rust-analyzer` #119070