Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crater] Remove LArrow #118920

Closed
wants to merge 1 commit into from
Closed

Conversation

compiler-errors
Copy link
Member

🔪

r? @ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 13, 2023
@compiler-errors
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Dec 13, 2023

⌛ Trying commit 1e147b4 with merge 3931cbb...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 13, 2023
[crater] Remove LArrow

🔪

r? `@ghost`
@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
GITHUB_ENV=/home/runner/work/_temp/_runner_file_commands/set_env_21baf634-64e4-44c7-aea0-b04a478e597e
GITHUB_EVENT_NAME=pull_request
GITHUB_EVENT_PATH=/home/runner/work/_temp/_github_workflow/event.json
GITHUB_GRAPHQL_URL=https://api.github.com/graphql
GITHUB_HEAD_REF=larrow
GITHUB_JOB=pr
GITHUB_PATH=/home/runner/work/_temp/_runner_file_commands/add_path_21baf634-64e4-44c7-aea0-b04a478e597e
GITHUB_REF=refs/pull/118920/merge
GITHUB_REF_NAME=118920/merge
GITHUB_REF_PROTECTED=false
---
    Checking toml_edit v0.19.11
    Checking serde_json v1.0.99
    Checking cargo_metadata v0.15.4
    Checking toml v0.7.5
error[E0599]: no variant or associated item named `LArrow` found for enum `TokenKind` in the current scope
     |
     |
1063 |         | TokenKind::LArrow
     |                      |
     |                      variant or associated item not found in `TokenKind`
     |                      help: there is a variant with a similar name: `RArrow`

@bors
Copy link
Contributor

bors commented Dec 13, 2023

☀️ Try build successful - checks-actions
Build commit: 3931cbb (3931cbb869e499bf6db1e4d580cc247efbf183df)

@compiler-errors
Copy link
Member Author

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-118920 created and queued.
🤖 Automatically detected try build 3931cbb
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2023
@Skgland
Copy link
Contributor

Skgland commented Dec 13, 2023

Rust-for-Linux appears to uses <- in their pin_init! macro e.g. https://github.com/Rust-for-Linux/linux/blob/rust-next/rust/kernel/sync/condvar.rs#L99

@compiler-errors
Copy link
Member Author

@Skgland: This shouldn't affect that macro unless it's actually choosing between <- and < - in the macro definition, which it seems it doesn't.

The only side-effect is that it causes field < - expr to work, since <- is now two tokens.

@craterbot
Copy link
Collaborator

🚧 Experiment pr-118920 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-118920 is completed!
📊 33 regressed and 3 fixed (399389 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Dec 19, 2023
@compiler-errors
Copy link
Member Author

@craterbot
Copy link
Collaborator

👌 Experiment pr-118920-1 created and queued.
🤖 Automatically detected try build 3931cbb
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2023
@craterbot
Copy link
Collaborator

🚧 Experiment pr-118920-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-118920-1 is completed!
📊 30 regressed and 0 fixed (33 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Dec 27, 2023
@compiler-errors
Copy link
Member Author

There are real crate breakages here. I don't believe we will be able to remove LArrow from the language without breaking existing macros.

@compiler-errors compiler-errors deleted the larrow branch January 8, 2024 14:56
@petrochenkov
Copy link
Contributor

I don't think we need to remove it in the first place.
It's a good looking operator with a high chance of being used in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants