Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): remove check for echo #118899

Merged
merged 1 commit into from
Jan 5, 2024
Merged

fix(tests): remove check for echo #118899

merged 1 commit into from
Jan 5, 2024

Conversation

veera-sivarajan
Copy link
Contributor

@veera-sivarajan veera-sivarajan commented Dec 13, 2023 •
edited
Loading

fixes: #56222

Removes check for echo as it doesn't seem to be used anywhere.

@rustbot
Copy link
Collaborator

rustbot commented Dec 13, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 13, 2023
@workingjubilee
Copy link
Member

...wait, what part of this test requires echo, anyways?

@veera-sivarajan
Copy link
Contributor Author

Ah yeah, I'm not sure but assumed it would be required by some other dependency since this check has persisted through so many changes.

Mark-Simulacrum
Mark-Simulacrum reviewed Dec 16, 2023
View reviewed changes
tests/run-make-fulldeps/hotplug_codegen_backend/Makefile Outdated
@@ -6,8 +6,11 @@ include ../../run-make/tools.mk
# backends and that this external codegen backend is only included in the dep info if
# -Zbinary-dep-depinfo is used.

REQUIRED := echo # This test requires `echo` to exist
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you help me understand what echo is used for in the test? It seems like the previous implementation presumably wanted specifically /bin/echo, not some other path... But I'm not seeing where that usage happens.

Asking the user to install echo seems basically useless, I don't think anyone who doesn't have it is likely to be willing/able to install it...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see the discussion thread now. I would recommend we drop this check and try and merge. Maybe that finds something, otherwise we can, well, just not have the check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I've removed the check.

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Dec 16, 2023 •
edited
Loading

r=me with commits squashed (and PR title + description updated)

@veera-sivarajan veera-sivarajan changed the title fix(tests): improve check to assert echo exists in path fix(tests): remove check for echo Dec 19, 2023
@veera-sivarajan
fix(tests): remove check for echo
67aec94 
Remove check for `echo`
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=iffy

@bors
Copy link
Contributor

bors commented Dec 31, 2023

📌 Commit 67aec94 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 31, 2023
@bors
Copy link
Contributor

bors commented Jan 1, 2024

⌛ Testing commit 67aec94 with merge 478d825...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 1, 2024
@bors
Auto merge of rust-lang#118899 - veera-sivarajan:fix-makefile, r=Mark…
478d825 
…-Simulacrum

fix(tests): remove check for `echo`

fixes: rust-lang#56222

Removes check for `echo` as it doesn't seem to be used anywhere.
@bors
Copy link
Contributor

bors commented Jan 1, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 1, 2024
@ehuss
Copy link
Contributor

ehuss commented Jan 1, 2024

@bors retry

Apple runner billing issue.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2024
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Jan 5, 2024

⌛ Testing commit 67aec94 with merge 8d39ec1...

@bors
Copy link
Contributor

bors commented Jan 5, 2024

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 8d39ec1 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 5, 2024
@bors bors merged commit 8d39ec1 into rust-lang:master Jan 5, 2024
12 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Jan 5, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8d39ec1): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.8% [1.4%, 6.2%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.091s -> 669.803s (0.11%)
Artifact size: 311.11 MiB -> 311.12 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.

run-make-fulldeps/hotplug_codegen_backend is too presumptuous in checking for its dependencies
8 participants
@veera-sivarajan @rustbot @workingjubilee @Mark-Simulacrum @bors @ehuss @rust-log-analyzer @rust-timer