Subtree update of `rust-analyzer` #118592

lnicola · 2023-12-04T07:21:02Z

refactor: replace multiple steps with `positions` in `fetch_workspaces` for clarity.

…m-ra

minor: Sync from rust

internal: simplify the removal of dulicate workspaces. ### Summary: Refactoring the duplicate removal process for `workspaces` in `fetch_workspaces`. ### Changes Made: Replaced `[].iter().enumerate().skip(...).filter_map(...)` with a more concise `[i+1..].positions(...)` provided by `itertools`, which enhances clarity without changing functionality ### Impact: This change aims to enhance the duplicate removal process for `workspaces`. This change has been tested on my machine. Please review and provide feedback. Thanks!

fix: remove parenthesis should ensure space close rust-lang/rust-analyzer#15844

fix variant resolve for type alias Closes rust-lang#15943

…icola internal: bump triomphe to 0.1.10

variable name change for clearer usage indication

Before it was inserting whenever function field is found but it should happend only in the case of function call.

fix: don't make `MissingMatchArms` diagnostic for empty match body before <img width="423" alt="before" src="https://github.com/rust-lang/rust-analyzer/assets/71162630/5c0e46fb-0c03-42f2-96ff-8e5245c25965"> after <img width="423" alt="after" src="https://github.com/rust-lang/rust-analyzer/assets/71162630/e2479dc5-3634-479b-af29-0b0ec7dc4a4f"> close rust-lang/rust-analyzer#15954

…r=Veykril fix: Err for comma after functional update syntax Error message copied from rustc, https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=20aeedb2db504c4e4ced54b665e761d6. Fixes rust-lang#15989.

…eykril Debug use cargo workspace root as `cwd` fixes rust-lang#13022

This commit addresses the issue of excessive and unrelated errors generated by top-level `let` statements. Now, only a single error is produced, indicating that `let` statements are invalid at the top level.

Improve error handling for top-level `let` statements This commit addresses the issue of excessive and unrelated errors generated by top-level `let` statements. Now, only a single error is produced, indicating that `let` statements are invalid at the top level. --- Fixes rust-lang/rust-analyzer#14963. While I'm not really sure if handling a particular case in a special manner is appropriate, it would be good to suppress the excessive number of annoying and unrelated errors.

Initial support for implicit drop inlay hint cc rust-lang#15785

Implement completion for the callable fields. Fixes rust-lang#14656 PR is opened with basic changes. It could be improved by having a new `SymbolKind` for the callable fields and implementing a separate render function similar to the `render_method` for the new `SymbolKind`. It could also be done without any changes to the `SymbolKind` of course, have the new function called based on the type of field. I prefer the former method. Please give any thoughts or changes you think is appropriate for this method. I could start working on that in this same PR.

…m-ra

rustbot · 2023-12-04T07:21:06Z

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

lnicola · 2023-12-04T07:21:22Z

@bors r+ p=1 subtree sync

bors · 2023-12-04T07:21:25Z

📌 Commit 638ba5a has been approved by lnicola

It is now in the queue for this repository.

bors · 2023-12-04T09:04:31Z

⌛ Testing commit 638ba5a with merge ec18471...

Subtree update of `rust-analyzer` r? `@ghost`

rust-log-analyzer · 2023-12-04T09:46:11Z

The job x86_64-gnu-aux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

thread 'main' panicked at src/tools/cargotest/main.rs:148:13:
assertion failed: status.success()
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Build completed unsuccessfully in 0:37:38
make: *** [Makefile:51: check-aux] Error 1
  network time: Mon, 04 Dec 2023 09:45:59 GMT
##[error]Process completed with exit code 2.
Post job cleanup.

bors · 2023-12-04T09:46:41Z

💔 Test failed - checks-actions

lnicola · 2023-12-04T09:54:10Z

Looks like this failed because cargotest fetches master, and servo/servo#30788 just happened.

CC @onur-ozkan

…Simulacrum Don't ask for a specific branch in cargotest Tentative fix for rust-lang#118592 (comment). `servo` [just renamed](servo/servo#30788) their `master` branch to `main`, but `cargotest` does a `git fetch $URL master; git reset --hard $SHA`. Let's try to change that to `git fetch $URL $SHA; git reset --hard $SHA`, which appears to work, but I can't confirm for sure because I'm having some trouble with `x.py`: ``` --> library/rustc-std-workspace-core/lib.rs:4:9 | 4 | pub use core::*; | ^^^^ | = note: the following crate versions were found: crate `core` compiled by rustc 1.76.0-nightly (85a4bd8 2023-12-04): ./build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libcore-70719e8645e6f000.rmeta = help: please recompile that crate using this compiler (rustc 1.76.0-nightly (5808b72 2023-12-04)) (consider running `cargo clean` first) ```

lnicola · 2023-12-04T14:47:02Z

@bors retry

bors · 2023-12-04T17:18:59Z

⌛ Testing commit 638ba5a with merge 0e2dac8...

bors · 2023-12-04T19:34:19Z

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 0e2dac8 to master...

rust-timer · 2023-12-04T20:56:42Z

Finished benchmarking commit (0e2dac8): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.7%	[2.7%, 2.7%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.8%	[5.8%, 5.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-2.1%, -2.1%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 674.521s -> 672.85s (-0.25%)
Artifact size: 314.16 MiB -> 314.17 MiB (0.00%)

Young-Flash and others added 30 commits November 9, 2023 18:33

fix: remove parenthesis should ensure space

be62e0b

remove unused PhantomData

97dea2c

move parentheses judge logic into builder

bd5a63b

internal: simplify the removal of dulicate workspaces.

e790d7f

refactor: replace multiple steps with `positions` in `fetch_workspaces` for clarity.

fix variant resolve for type alias

2411f13

fix: don't make MissingMatchArms diagnostic for empty match body

cab9148

Merge commit '237712fa314237e428e7ef2ab83b979f928a43a1' into sync-fro…

81606ec

…m-ra

Merge branch 'master' into sync-from-rust

57172f7

Auto merge of rust-lang#15976 - lnicola:sync-from-rust, r=lnicola

23dc01f

minor: Sync from rust

Auto merge of rust-lang#15857 - Young-Flash:fix, r=Veykril

4ab6729

fix: remove parenthesis should ensure space close rust-lang/rust-analyzer#15844

Auto merge of rust-lang#15970 - Austaras:master, r=Veykril

2ee17bc

fix variant resolve for type alias Closes rust-lang#15943

internal: bump triomphe to 0.1.10

914a157

Auto merge of rust-lang#15985 - davidbarsky:david/bump-triomphe, r=ln…

c7c582a

…icola internal: bump triomphe to 0.1.10

add different completion for fn fields

a0e690a

implement completion render for callable fields

7cf3ab4

add tests for the completion of the callable field

5bcafd7

refactor obtaining receivers into idiomatic way

eedeb58

variable name change for clearer usage indication

add tests for tuple fields and expect fn type cases

aa1cf8d

fix the insertion of the surronding parens

8296b16

Before it was inserting whenever function field is found but it should happend only in the case of function call.

refactor complete_fn_fields function and correct branch checks

5c0c8ce

update dot tests function with check_edit

21c09eb

Debug use cargo workspace root as cwd. fixes rust-lang#13022

4ca86ed

update: filter out syntax error in test

b46f378

Err for comma after functional update syntax

2fd19ed

Auto merge of rust-lang#15993 - meowtec:fix/workspaces-debug-cwd, r=V…

c9d189d

…eykril Debug use cargo workspace root as `cwd` fixes rust-lang#13022

Improve error handling for top-level let statements

e076192

This commit addresses the issue of excessive and unrelated errors generated by top-level `let` statements. Now, only a single error is produced, indicating that `let` statements are invalid at the top level.

HKalbasi and others added 5 commits December 1, 2023 16:16

Initial support for implicit drop inlay hint

4d55cac

fix close parens position to move after field access

b7effe5

Auto merge of rust-lang#16000 - HKalbasi:drop-inlay-hint, r=HKalbasi

6e6a0b0

Initial support for implicit drop inlay hint cc rust-lang#15785

Merge commit 'e402c494b7c7d94a37c6d789a216187aaf9ccd3e' into sync-fro…

638ba5a

…m-ra

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 4, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 4, 2023

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 4, 2023

Auto merge of rust-lang#118592 - lnicola:sync-from-ra, r=lnicola

ec18471

Subtree update of `rust-analyzer` r? `@ghost`

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 4, 2023

lnicola mentioned this pull request Dec 4, 2023

Don't ask for a specific branch in cargotest #118597

Merged

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 4, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 4, 2023

bors merged commit 0e2dac8 into rust-lang:master Dec 4, 2023
11 checks passed

rustbot added this to the 1.76.0 milestone Dec 4, 2023

lnicola deleted the sync-from-ra branch December 4, 2023 19:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Subtree update of `rust-analyzer` #118592

Subtree update of `rust-analyzer` #118592

lnicola commented Dec 4, 2023

rustbot commented Dec 4, 2023

lnicola commented Dec 4, 2023

bors commented Dec 4, 2023

bors commented Dec 4, 2023

rust-log-analyzer commented Dec 4, 2023

bors commented Dec 4, 2023

lnicola commented Dec 4, 2023

lnicola commented Dec 4, 2023

bors commented Dec 4, 2023

bors commented Dec 4, 2023

rust-timer commented Dec 4, 2023

Subtree update of rust-analyzer #118592

Subtree update of rust-analyzer #118592

Conversation

lnicola commented Dec 4, 2023

rustbot commented Dec 4, 2023

lnicola commented Dec 4, 2023

bors commented Dec 4, 2023

bors commented Dec 4, 2023

rust-log-analyzer commented Dec 4, 2023

bors commented Dec 4, 2023

lnicola commented Dec 4, 2023

lnicola commented Dec 4, 2023

bors commented Dec 4, 2023

bors commented Dec 4, 2023

rust-timer commented Dec 4, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Subtree update of `rust-analyzer` #118592

Subtree update of `rust-analyzer` #118592