-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ICE ProjectionKinds Deref and Field were mismatched
#118584
Fix ICE ProjectionKinds Deref and Field were mismatched
#118584
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
Also cc @wesleywiser since they opened the original PR #89208 |
@WaffleLapkin please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me after fixing nit picks
✌️ @gurry, you can now approve this pull request! If @WaffleLapkin told you to " |
btw @wesleywiser please take a look anyway, in case I've missed something |
4fb887d
to
c3a739e
Compare
☀️ Test successful - checks-actions |
Finished benchmarking commit (a7690a3): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 673.754s -> 673.256s (-0.07%) |
Fix #118144
Removed the check that ICEd if the sequence of projection kinds were different across captures. Instead we now sort based only on
Field
projection kinds.