Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make handle_options public again. #116827

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Make handle_options public again. #116827

merged 1 commit into from
Oct 17, 2023

Conversation

nnethercote
Copy link
Contributor

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 17, 2023
nnethercote referenced this pull request Oct 17, 2023
@nnethercote
Remove unneeded pubs.
2b4c338
@nnethercote
Copy link
Contributor Author

@bors rollup=always

@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 17, 2023

📌 Commit 3b071ef has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@compiler-errors
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 17, 2023
@nnethercote
Copy link
Contributor Author

I added <> to the URL.

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Oct 17, 2023

📌 Commit b0e1a52 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 17, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 17, 2023
@matthiaskrgr
Rollup merge of rust-lang#116827 - nnethercote:pub-handle_options, r=…
dbbe6e5 
…compiler-errors

Make `handle_options` public again.

r? `@compiler-errors`
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 17, 2023
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 17, 2023
@bors
Auto merge of rust-lang#116848 - matthiaskrgr:rollup-y4e025o, r=matth…
6bdfdf5 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#116717 (Special case iterator chain checks for suggestion)
 - rust-lang#116719 (Add MonoItems and Instance to stable_mir)
 - rust-lang#116787 (Implement an internal lint encouraging use of `Span::eq_ctxt`)
 - rust-lang#116827 (Make `handle_options` public again.)
 - rust-lang#116838 (Fix duplicate labels emitted in `render_multispan_macro_backtrace()`)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 17, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 17, 2023
@bors
Auto merge of rust-lang#116855 - matthiaskrgr:rollup-i2izdwb, r=matth…
94ba57c 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#111072 (Add new simpler and more explicit syntax for check-cfg)
 - rust-lang#116717 (Special case iterator chain checks for suggestion)
 - rust-lang#116719 (Add MonoItems and Instance to stable_mir)
 - rust-lang#116787 (Implement an internal lint encouraging use of `Span::eq_ctxt`)
 - rust-lang#116827 (Make `handle_options` public again.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6e6cd68 into rust-lang:master Oct 17, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 17, 2023
@rust-timer
Unrolled build for rust-lang#116827
c438dfb 
Rollup merge of rust-lang#116827 - nnethercote:pub-handle_options, r=compiler-errors

Make `handle_options` public again.

r? ``@compiler-errors``
@rustbot rustbot added this to the 1.75.0 milestone Oct 17, 2023
@nnethercote nnethercote deleted the pub-handle_options branch October 17, 2023 21:14
@Veykril Veykril mentioned this pull request Oct 18, 2023
Merged
bors-ferrocene bot added a commit to ferrocene/ferrocene that referenced this pull request Oct 18, 2023
@bors-ferrocene @Urgau
@estebank @fee1-dead @RalfJung @cjgillot @celinval @nnethercote @a-lafrance @nikarh @nikic @bors
Merge #57
f251156 
57: Pull upstream master 2023 10 18 r=pietroalbini a=Veykril

* rust-lang/rust#116505
* rust-lang/rust#116840
* rust-lang/rust#116767
* rust-lang/rust#116855
  * rust-lang/rust#116827
  * rust-lang/rust#116787
  * rust-lang/rust#116719
  * rust-lang/rust#116717
  * rust-lang/rust#111072
* rust-lang/rust#116844
* rust-lang/rust#115577
* rust-lang/rust#116756
* rust-lang/rust#116518



Co-authored-by: Urgau <[email protected]>
Co-authored-by: Esteban Küber <[email protected]>
Co-authored-by: Deadbeef <[email protected]>
Co-authored-by: Ralf Jung <[email protected]>
Co-authored-by: Camille GILLOT <[email protected]>
Co-authored-by: Celina G. Val <[email protected]>
Co-authored-by: Nicholas Nethercote <[email protected]>
Co-authored-by: Arthur Lafrance <[email protected]>
Co-authored-by: Nikolay Arhipov <[email protected]>
Co-authored-by: Nikita Popov <[email protected]>
Co-authored-by: bors <[email protected]>
@nnethercote nnethercote mentioned this pull request Oct 28, 2023
Merged
bjorn3
bjorn3 reviewed Jan 10, 2025
View reviewed changes
compiler/rustc_driver_impl/src/lib.rs
///
/// This does not need to be `pub` for rustc itself, but @chaosite needs it to
/// be public when using rustc as a library, see
/// <https://github.com/rust-lang/rust/commit/2b4c33817a5aaecabf4c6598d41e190080ec119e>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it is the wrong commit. I don't see any where that this person requested the function to remain public. Neither on that commit itself, nor on the associated PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nnethercote do you remember what the correct commit is?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the right commit. There is a comment added to that commit after it merged, but it's easy to overlook in the GitHub UI. This link should be better, it links directly to the comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.75.0
Development

Successfully merging this pull request may close these issues.
6 participants
@nnethercote @compiler-errors @bors @rust-log-analyzer @bjorn3 @rustbot