-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consistently pass ty::Const through valtrees #115804
Conversation
r? @davidtwco (rustbot has picked a reviewer for you, use r? to override) |
44e7970
to
19fb2c7
Compare
I rebased over #115803 and made this PR the logical next step -- consistently pass all ty::Const through valtrees, never short-cutting directly to a ConstValue. Let's see what perf says. |
This comment has been minimized.
This comment has been minimized.
consistently pass ty::Const through valtrees Some drive-by things extracted from rust-lang#115748.
☀️ Try build successful - checks-actions |
1 similar comment
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (c7767b6): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 631.545s -> 631.288s (-0.04%) |
That looks promising. :) |
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (e437e57): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 630.976s -> 632.742s (0.28%) |
Some drive-by things extracted from #115748.