-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor thread_info
to remove the RefCell
#115753
Conversation
r? @thomcc (rustbot has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
afaeae3
to
52ff0f8
Compare
This comment has been minimized.
This comment has been minimized.
52ff0f8
to
e5c8169
Compare
This comment has been minimized.
This comment has been minimized.
`thread_info` currently uses `RefCell`-based initialization. Refactor this to use `OnceCell` instead which is more performant and better suits the needs of one-time initialization.
e5c8169
to
207b609
Compare
Thanks. @bors r+ rollup=never |
☀️ Test successful - checks-actions |
Finished benchmarking commit (ed33e40): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 631.695s -> 632.622s (0.15%) |
thread_info
currently usesRefCell
-based initialization. Refactor this to useOnceCell
instead which is more performant and better suits the needs of one-time initialization.This is nobody's bottleneck but OnceCell checks are a single
cmp
vs.RefCell<Option>
needing runtime logic