-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ICE monomorphize collection encountered polymorphic constant #114985
Conversation
r? @TaKO8Ki (rustbot has picked a reviewer for you, use r? to override) |
Does this also fix the other ones? |
Seems this is a regression case that we need fix from the root cause, instead of covering the errors. |
Also, this needs a very detailed explanation why it's correct. Adding a new fatal during codegen doesn't seem right, especially without the generic_const_exprs feature being enabled. |
This is an overflow error:
So even if we are gonna fatally error here, the wording needs to explain that it's an overflow, not just "polymorphic". |
☔ The latest upstream changes (presumably #115553) made this pull request unmergeable. Please resolve the merge conflicts. |
Fixes #114484