Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 5 pull requests #114366

Closed
wants to merge 7 commits into from
Closed

Rollup of 5 pull requests #114366

wants to merge 7 commits into from

Conversation

Noratrieb
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

RalfJung and others added 7 commits August 1, 2023 18:23
@RalfJung
fix and extend ptr_comparison test
69b02ef
@chenyukang
print more detailed format files and untracked files count
79709e5
@chenyukang
fmt_override is a better name since we are also adding files to white…
58bda47 
…list
@compiler-errors
Use upvar_tys in more places, make it a list
99969d2
@Noratrieb
Rollup merge of rust-lang#114079 - compiler-errors:closure-upvars, r=…
3edc51b 
…oli-obk

Use `upvar_tys` in more places, make it return a list

Just a cleanup that fell out of a PR that I was gonna write, but that PR kinda got stuck.
@Noratrieb
Rollup merge of rust-lang#114335 - RalfJung:ptr_comparisons, r=oli-obk
615be67 
fix and extend ptr_comparison test

r? `@oli-obk`
@Noratrieb
Rollup merge of rust-lang#114347 - chenyukang:yukang-fix-114245-fmt-c…
f35308c 
…ount, r=albertlarsan68

x.py print more detailed format files and untracked files count

Fixes rust-lang#114245
@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Aug 2, 2023
@Noratrieb
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Aug 2, 2023

📌 Commit f35308c has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 2, 2023
@fmease
Copy link
Member

fmease commented Aug 2, 2023 •
edited
Loading

#114353 failed CI (rustfmt): #114353 (comment)

@lqd
Copy link
Member

lqd commented Aug 2, 2023

what do you mean ? #114253 is not r+ed nor in the rollup.

@Noratrieb
Copy link
Member Author

you messed up the number, but I see

@Noratrieb
Copy link
Member Author

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 2, 2023
@Noratrieb
Copy link
Member Author

it's #114353

@Noratrieb Noratrieb closed this Aug 2, 2023
@fmease
Copy link
Member

fmease commented Aug 2, 2023

yea, sorry copy/pasted the wrong thing, I meant #114353

@lqd
Copy link
Member

lqd commented Aug 2, 2023 •
edited
Loading

Note that bors/whatever also messed up the rollup again, it mentions 5 PRs but has rolled up 3.

@Noratrieb
Copy link
Member Author

the follow-up got all 5: #114367 !!!

@Noratrieb
Copy link
Member Author

lol, #114353 was among the unlucky ones, so this rollup would have actually passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rollup A PR which is a rollup S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Noratrieb @bors @fmease @lqd @rustbot @RalfJung @chenyukang @compiler-errors