interpret: fix alignment handling for Repeat expressions #114296
Conversation
|
r? @jackh726 (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
The Miri subtree was changed cc @rust-lang/miri Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri |
|
Is there some context that motivated this change? |
|
It fixes a bug. :) The new testcase src/tools/miri/tests/pass/align_repeat_into_packed_field.rs is currently accidentally UB but that should be allowed. |
RalfJung
force-pushed
the
interpret-repeat-align
branch
from
641125e to
b169ee7
Compare
|
yea, I was just wondering if there was any discussion that made you realize that, but it seems to just be careful code reading 😆 @bors r+ |
bors
added
S-waiting-on-bors
|
The full story is that I did some research for rust-lang/opsem-team#11, then I found #54547 which led me to #56927 and #57053 and reading that PR I realized I should double-check what Miri does and then found the problem in |
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#100455 (Implement RefUnwindSafe for Backtrace) - rust-lang#113428 (coverage: Replace `ExpressionOperandId` with enum `Operand`) - rust-lang#114283 (Use parking lot's rwlock even without parallel-rustc) - rust-lang#114288 (Improve diagnostic for wrong borrow on binary operations) - rust-lang#114296 (interpret: fix alignment handling for Repeat expressions) - rust-lang#114306 ([rustc_data_structures][perf] Simplify base_n::push_str.) - rust-lang#114320 (Cover statements for stable_mir) r? `@ghost` `@rustbot` modify labels: rollup
No description provided.