Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove constness from ParamEnv #114134

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Remove constness from ParamEnv #114134

merged 3 commits into from
Jul 28, 2023

Conversation

fee1-dead
Copy link
Member

@fee1-dead fee1-dead commented Jul 27, 2023 •
edited
Loading

This should be replaced by keyword generics/effects. cc #110395

r? @oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jul 27, 2023
@fee1-dead fee1-dead marked this pull request as ready for review July 27, 2023 15:53
@rustbot
Copy link
Collaborator

rustbot commented Jul 27, 2023

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@oli-obk
Copy link
Contributor

oli-obk commented Jul 28, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Jul 28, 2023

📌 Commit b0fa220 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2023
@bors
Copy link
Contributor

bors commented Jul 28, 2023

⌛ Testing commit b0fa220 with merge aafd75a...

@bors
Copy link
Contributor

bors commented Jul 28, 2023

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing aafd75a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 28, 2023
@bors bors merged commit aafd75a into rust-lang:master Jul 28, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 28, 2023
This was referenced Jul 28, 2023
Closed
Merged
Merged
Merged
@lcnr lcnr removed the WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) label Jul 28, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 28, 2023
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (aafd75a): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.4% [-0.6%, -0.3%] 23
Improvements ✅
(secondary)		 -0.5% [-0.7%, -0.3%] 16
All ❌✅ (primary) -0.4% [-0.6%, -0.3%] 23

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.3% [-3.1%, -1.6%] 2
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.4% [-2.6%, -2.3%] 3
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 652.048s -> 651.183s (-0.13%)

@fee1-dead fee1-dead deleted the rm-constness-from-param-env branch July 29, 2023 08:11
flip1995 pushed a commit to flip1995/rust that referenced this pull request Aug 11, 2023
@bors
Auto merge of rust-lang#114134 - fee1-dead-contrib:rm-constness-from-…
e97a770 
…param-env, r=oli-obk

Remove `constness` from `ParamEnv`

This should be replaced by keyword generics/effects. cc rust-lang#110395

r? `@oli-obk`
@fee1-dead fee1-dead mentioned this pull request May 21, 2023
Closed
4 tasks
@oli-obk oli-obk mentioned this pull request Sep 4, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 7, 2023
@bors
Auto merge of rust-lang#115527 - oli-obk:drop_maybe_uninit_in_const, …
1e746d7 
…r=lcnr

Don't require `Drop` for `[PhantomData<T>; N]` where `N` and `T` are generic, if `T` requires `Drop`

fixes rust-lang#115403
fixes rust-lang#115410

This was accidentally regressed in rust-lang#114134, because it was accidentally stabilized in rust-lang#102204 (cc `@rust-lang/lang,` seems like an innocent stabilization, considering this PR is more of a bugfix than a feature).

While we have a whole month to beta backport this change before the regression hits stable, I'd still prefer not to go through an FCP on this PR (which fixes a regression), if T-lang wants an FCP, I can can open an issue about the change itself.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Sep 12, 2023
@bors
Auto merge of #115527 - oli-obk:drop_maybe_uninit_in_const, r=lcnr
f9f4806 
Don't require `Drop` for `[PhantomData<T>; N]` where `N` and `T` are generic, if `T` requires `Drop`

fixes rust-lang/rust#115403
fixes rust-lang/rust#115410

This was accidentally regressed in rust-lang/rust#114134, because it was accidentally stabilized in #102204 (cc `@rust-lang/lang,` seems like an innocent stabilization, considering this PR is more of a bugfix than a feature).

While we have a whole month to beta backport this change before the regression hits stable, I'd still prefer not to go through an FCP on this PR (which fixes a regression), if T-lang wants an FCP, I can can open an issue about the change itself.
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 7, 2023
Closed
4 tasks
@fee1-dead fee1-dead mentioned this pull request Dec 12, 2023
Merged
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 11, 2024
Closed
@Nadrieril Nadrieril mentioned this pull request May 28, 2024
Merged
This was referenced Jan 14, 2025
Merged
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 15, 2025
@matthiaskrgr
Rollup merge of rust-lang#135523 - RalfJung:wrong-known-bug, r=compil…
e4bbca2 
…er-errors

const traits: remove some known-bug that do not seem to make sense

These tests were made to point to rust-lang#103507 in rust-lang#114134; I think that was a mistake: that issue is about a rather specific problem, and most tests marked as known-bug in that PR are pointing at rust-lang#110395 which makes more sense.

Of the 4 tests that still point to rust-lang#103507:
- One is [the original test](https://github.com/rust-lang/rust/blob/20882608529a969bd878ad787cf0038716c021df/tests/ui/impl-trait/normalize-tait-in-const.rs). It still fails to compile, though currently for unrelated reasons (`~const Fn` is not valid as that is not a const trait). I made it point at rust-lang#110395 like all the other tests that were disabled when the previous const trait impl was removed.
- One is being fixed in rust-lang#135423
- The other two are fixed in this PR

The errors we are getting here are not great but they do look correct?

FWIW there are still a whole lot of tests mentioning rust-lang#110395 despite that issue being closed... I hope someone is tracking that.^^

r? `@compiler-errors`
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 16, 2025
@rust-timer
Unrolled build for rust-lang#135523
5556c27 
Rollup merge of rust-lang#135523 - RalfJung:wrong-known-bug, r=compiler-errors

const traits: remove some known-bug that do not seem to make sense

These tests were made to point to rust-lang#103507 in rust-lang#114134; I think that was a mistake: that issue is about a rather specific problem, and most tests marked as known-bug in that PR are pointing at rust-lang#110395 which makes more sense.

Of the 4 tests that still point to rust-lang#103507:
- One is [the original test](https://github.com/rust-lang/rust/blob/20882608529a969bd878ad787cf0038716c021df/tests/ui/impl-trait/normalize-tait-in-const.rs). It still fails to compile, though currently for unrelated reasons (`~const Fn` is not valid as that is not a const trait). I made it point at rust-lang#110395 like all the other tests that were disabled when the previous const trait impl was removed.
- One is being fixed in rust-lang#135423
- The other two are fixed in this PR

The errors we are getting here are not great but they do look correct?

FWIW there are still a whole lot of tests mentioning rust-lang#110395 despite that issue being closed... I hope someone is tracking that.^^

r? `@compiler-errors`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blyxyas blyxyas blyxyas left review comments

Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
8 participants
@fee1-dead @rustbot @rust-log-analyzer @oli-obk @bors @rust-timer @blyxyas @lcnr