Rollup of 3 pull requests

[matthiaskrgr]

Successful merges:

• Update documentation for tools defaults #112487 (Update documentation for tools defaults)
• Dont compute opt_suggest_box_span span for TAIT #112513 (Dont compute opt_suggest_box_span span for TAIT)
• bootstrap: Don't override debuginfo-level = 1 to mean line-tables-only #112528 (bootstrap: Don't override debuginfo-level = 1 to mean line-tables-only)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[matthiaskrgr]

@bors r+ rollup=never p=3

[bors]

📌 Commit c1f2da5 has been approved by matthiaskrgr

It is now in the queue for this repository.

[bors]

⌛ Testing commit c1f2da5 with merge 37998ab...

[bors]

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 37998ab to master...

[rust-timer]

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#112528	9959cdf35accd1b07fb2ac74635e10de483ec3a4
#112513	74b2d61c04d5d803c7fcc28a1cfc52fc8b5a2d46
#112487	d5db223c793e96736abaf8900a944fef307160e5

previous master: 81c02da94e

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

[rust-timer]

Finished benchmarking commit (37998ab): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	9.3%	[0.6%, 21.0%]	19
Regressions ❌ (secondary)	8.7%	[1.0%, 20.8%]	71
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	9.3%	[0.6%, 21.0%]	19

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.2%	[1.2%, 1.2%]	1
Regressions ❌ (secondary)	2.9%	[2.0%, 3.7%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.2%	[1.2%, 1.2%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	8.6%	[0.8%, 15.4%]	14
Regressions ❌ (secondary)	8.1%	[1.6%, 15.1%]	52
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	8.6%	[0.8%, 15.4%]	14

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	27.8%	[2.7%, 55.3%]	24
Regressions ❌ (secondary)	52.8%	[36.7%, 55.4%]	74
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	27.8%	[2.7%, 55.3%]	24

Bootstrap: 647.238s -> 650.784s (0.55%)

[Kobzol]

@rust-timer build 9959cdf35accd1b07fb2ac74635e10de483ec3a4

[lqd]

It's likely to be the #112528 partial revert indeed, as the initial PR had unexpected wins by seeping through libstd IIRC #110221 (comment)

[rust-timer]

Finished benchmarking commit (9959cdf35accd1b07fb2ac74635e10de483ec3a4): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	9.4%	[0.5%, 21.2%]	19
Regressions ❌ (secondary)	8.8%	[0.9%, 21.0%]	70
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	9.4%	[0.5%, 21.2%]	19

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.2%	[1.2%, 1.2%]	1
Regressions ❌ (secondary)	3.0%	[2.5%, 3.5%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	1.2%	[1.2%, 1.2%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	9.7%	[0.7%, 15.5%]	12
Regressions ❌ (secondary)	8.3%	[2.0%, 15.0%]	48
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	9.7%	[0.7%, 15.5%]	12

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	27.8%	[2.7%, 55.4%]	24
Regressions ❌ (secondary)	52.9%	[36.8%, 55.5%]	74
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	27.8%	[2.7%, 55.4%]	24

Bootstrap: 647.238s -> 647.582s (0.05%)

[pnkfelix]

• One of the rolled up PRs, PR bootstrap: Don't override debuginfo-level = 1 to mean line-tables-only #112528, is itself a partial revert of PR Greatly decrease the size of rustc_driver.so when debuginfo is enabled #110221, which yields the large compile-time losses noted here (solely for helloworld, it is worth noting).
• the point is, the gains were 1. accidental 2. isolated to a toy and 3. due to an unintended change (which was now reverted).
• marking as triaged.

@rustbot label: +perf-regression-triaged