Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] backport #111971

Merged
merged 3 commits into from
May 26, 2023
Merged

[beta] backport #111971

merged 3 commits into from
May 26, 2023

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented May 26, 2023

r? cuviper

compiler-errors and others added 3 commits May 25, 2023 17:14
@compiler-errors @cuviper
Dont check must_use on nested impl Future from fn
1a42cb7 
(cherry picked from commit 926e874)
@lcnr @cuviper
update recursion depth in confirm_candidate
a365f58 
(cherry picked from commit 1708ad6)
@lcnr @cuviper
add test
f2e37f7 
(cherry picked from commit c5ec1b8)
@rustbot
Copy link
Collaborator

rustbot commented May 26, 2023

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 26, 2023
@cuviper
Copy link
Member Author

cuviper commented May 26, 2023

@bors r+ rollup=never p=1

@bors
Copy link
Contributor

bors commented May 26, 2023

📌 Commit f2e37f7 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 26, 2023
@bors
Copy link
Contributor

bors commented May 26, 2023

⌛ Testing commit f2e37f7 with merge 2687f47...

@bors
Copy link
Contributor

bors commented May 26, 2023

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 2687f47 to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 26, 2023
@bors bors merged commit 2687f47 into rust-lang:beta May 26, 2023
@rustbot rustbot added this to the 1.70.0 milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.
5 participants
@cuviper @rustbot @bors @compiler-errors @lcnr