Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added TraitAlias to check_item() for missing_docs #111150

Merged
merged 1 commit into from
May 7, 2023
Merged

added TraitAlias to check_item() for missing_docs #111150

merged 1 commit into from
May 7, 2023

Conversation

mj10021
Copy link
Contributor

@mj10021 mj10021 commented May 3, 2023

As in issue #111025 the missing_docs was not being triggered for trait aliases. I added TraitAlias to the pattern match for check_item(), and the lint seems to be behaving appropriately

@rustbot
Copy link
Collaborator

rustbot commented May 3, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented May 3, 2023

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 3, 2023
@rustbot
Copy link
Collaborator

rustbot commented May 3, 2023

Some changes occurred in src/tools/cargo

cc @ehuss

@mj10021
Copy link
Contributor Author

mj10021 commented May 3, 2023

sry, fixing the cargo commit

@mj10021 mj10021 force-pushed the issue-111025-fix branch from 2e3d3b3 to df279bc Compare May 3, 2023 17:38
@petrochenkov
Copy link
Contributor

This needs a test case, added to tests/ui/lint/lint-missing-doc.rs, for example.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 5, 2023
@mj10021 mj10021 force-pushed the issue-111025-fix branch 2 times, most recently from 7381adf to 8bd819d Compare May 5, 2023 20:47
@mj10021
Copy link
Contributor Author

mj10021 commented May 5, 2023

Does that look right then?

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 5, 2023
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2023
@mj10021 mj10021 force-pushed the issue-111025-fix branch from 8bd819d to 58d7861 Compare May 6, 2023 14:27
petrochenkov
petrochenkov reviewed May 6, 2023
View reviewed changes
compiler/rustc_lint/src/builtin.rs Outdated Show resolved Hide resolved
tests/ui/lint/lint-missing-doc.rs Outdated Show resolved Hide resolved
@petrochenkov
Copy link
Contributor

The src/tools/cargo submodule should not be updated.

Could you also squash commits into one after addressing all the comments?

@mj10021 mj10021 force-pushed the issue-111025-fix branch 2 times, most recently from 9555efc to 7373c1f Compare May 6, 2023 22:31
@mj10021 mj10021 force-pushed the issue-111025-fix branch from 7373c1f to fd005b0 Compare May 6, 2023 22:32
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented May 6, 2023

📌 Commit fd005b0 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 6, 2023
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 6, 2023
@JohnTitor JohnTitor mentioned this pull request May 7, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 7, 2023
@bors
Auto merge of rust-lang#111311 - JohnTitor:rollup-vfpjm0d, r=JohnTitor
8cc75b5 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#105583 (Operand::extract_field: only cast llval if it's a pointer and replace bitcast w/ pointercast.)
 - rust-lang#110094 (clean up `transmute`s in `core`)
 - rust-lang#111150 (added TraitAlias to check_item() for missing_docs)
 - rust-lang#111293 (rustc --explain E0726 - grammar fixing (it's => its + add a `the` where it felt right to do so))
 - rust-lang#111300 (Emit while_true lint spanning the entire loop condition)
 - rust-lang#111301 (Remove calls to `mem::forget` and `mem::replace` in `Option::get_or_insert_with`.)
 - rust-lang#111303 (update Rust Unstable Book docs for `--extern force`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 61115cd into rust-lang:master May 7, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 7, 2023
@fmease
Copy link
Member

fmease commented Jun 24, 2023

Issue #111025 should now be closed, right?. It wasn't auto-closed as the PR description didn't contain a trigger like Fixes.

@mj10021 mj10021 deleted the issue-111025-fix branch November 1, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mj10021 @rustbot @petrochenkov @bors @fmease