Attempt to fix the segfaulting osx bots #11110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upon inspecting the core dumps, they're all segfaulting at the same instruction with the same value in a register that looks fishy. It appears to be indexing into an array with a -1 index and then getting some weird overflow and dying. I have attempted to fix this as part of alexcrichton/libuv@fd53083, but I am unsure of whether this is the actual cause of the problem, so I am not going to upstream it just yet. I have a fairly high confidence that this is indeed the problem, but I want to make sure that the bots to segfault all over the place before upstreaming.
|
cc @brson |
|
Upon thinking about this, I am far more certain that this is our issue than before, and I have opened a pull request against libuv with joyent/libuv#1052 |
|
Nice find. |
bors
added a commit
that referenced
this pull request
Dec 22, 2013
…ng, r=brson Upon inspecting the core dumps, they're all segfaulting at the same instruction with the same value in a register that looks fishy. It appears to be indexing into an array with a -1 index and then getting some weird overflow and dying. I have attempted to fix this as part of alexcrichton/libuv@fd53083, but I am unsure of whether this is the actual cause of the problem, so I am not going to upstream it just yet. I have a fairly high confidence that this is indeed the problem, but I want to make sure that the bots to segfault all over the place before upstreaming.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 14, 2023
…_expn, r=Jarcho [`unnecessary_literal_unwrap`]: don't lint if binding initializer comes from expansion Fixes rust-lang/rust-clippy#11109 changelog: [`unnecessary_literal_unwrap`]: don't lint if binding initializer comes from expansion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon inspecting the core dumps, they're all segfaulting at the same instruction
with the same value in a register that looks fishy. It appears to be indexing
into an array with a -1 index and then getting some weird overflow and dying.
I have attempted to fix this as part of
alexcrichton/libuv@fd53083,
but I am unsure of whether this is the actual cause of the problem, so I am not
going to upstream it just yet. I have a fairly high confidence that this is
indeed the problem, but I want to make sure that the bots to segfault all over
the place before upstreaming.