-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #110880
Closed
Closed
Rollup of 8 pull requests #110880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The infra-team is continuously monitoring the efficiency of the build system in an effort to improve overall build times and resource usage. The builders for the `i686-gnu` targets have used much less resources than allocated in the past, so we are testing a smaller builder size for them.
The infra-team is continuously monitoring the efficiency of the build system in an effort to improve overall build times and resource usage. The builder for the `mingw-check` target have used much less resources than allocated in the past, so we are testing a smaller builder size for it.
The infra-team is continuously monitoring the efficiency of the build system in an effort to improve overall build times and resource usage. The builders for some of the `x86_64-gnu` targets have used much less resources than allocated in the past, so we are testing a smaller builder size for them.
Signed-off-by: cui fliter <[email protected]>
Co-authored-by: Michael Goulet <[email protected]>
…mples, r=compiler-errors docs(style): add more let-else examples Adding a few more examples for increased clarity based on subsequent discussion that arose after implementation work began. Will need approval from t-style, but also cc ``@ytmimi`` to make sure these examples don't contradict any examples we've been incorporating as part of the rustfmt implementation
Remove repeated definite articles
…ilstrieb Sprinkle some `#[inline]` in `rustc_data_structures::tagged_ptr` This is based on `nm --demangle (rustc +a --print sysroot)/lib/librustc_driver-*.so | rg CopyTaggedPtr` which shows many methods that should probably be inlined. May fix the regression in rust-lang#110795. r? ``@Nilstrieb``
…, r=compiler-errors Migrate `rustc_passes` to translatable diagnostics cc rust-lang#100717
…oalbini Optimize builder sizes The infra-team is continuously monitoring the efficiency of the CI system in an effort to improve overall build times and resource usage. Some builders have used much less than their allocated resources, so we are testing smaller builder sizes for them. r? ``@pietroalbini``
…, r=jackh726 `IntoFuture::into_future` is no longer unstable We don't need to gate the `IntoFuture::into_future` call in `.await` lowering anymore. `@bors` rollup
Make `method-not-found-generic-arg-elision.rs` error message not path dependent Every time I bless `tests/ui/methods/method-not-found-generic-arg-elision.rs`, I get some nonsense "type is too long" + "written to disk" that shows up and have to manually revert because the combination of my rustc repo path + the UI test directory hits the length limit for printing types spilling to disk (since this happens before UI test path sanitization). The fact that we use a closure in this test doesn't have to do with the UI test, so just box the closure to make the type name smaller and not path dependent.
…ywiser Nicer ICE for rust-lang#67981 Provides a slightly nicer ICE for rust-lang#67981, documenting the problem. A proper fix will be necessary before `#![feature(unsized_fn_params)]` can be stabilized. The problem is that the design of the `"rust-call"` ABI is fundamentally not compatible with `unsized_fn_params`. `"rust-call"` functions need to collect their arguments into a tuple, but if the arguments are not `Sized`, said tuple is potentially not even a valid type—and if it is, it requires `alloca` to create. `@rustbot` label +A-abi +A-codegen +F-unboxed_closures +F-unsized_fn_params
@bors r+ rollup=never p=8 |
⌛ Testing commit 1f3f65b with merge 9e2b697d5d8358deed0d6a8bacc1f5d6e1cacce2... |
@bors r+ |
💡 This pull request was already approved, no need to approve it again.
|
⌛ Testing commit 1f3f65b with merge b2c2088aedab907704b249be66c845e6b724728f... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-testsuite
Area: The testsuite used to check the correctness of rustc
rollup
A PR which is a rollup
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-infra
Relevant to the infrastructure team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
T-style
Relevant to the style team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
#[inline]
inrustc_data_structures::tagged_ptr
#110814 (Sprinkle some#[inline]
inrustc_data_structures::tagged_ptr
)rustc_passes
to translatable diagnostics #110816 (Migraterustc_passes
to translatable diagnostics)IntoFuture::into_future
is no longer unstable #110864 (IntoFuture::into_future
is no longer unstable)method-not-found-generic-arg-elision.rs
error message not path dependent #110866 (Makemethod-not-found-generic-arg-elision.rs
error message not path dependent)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup