allow ReError in CanonicalUserTypeAnnotation #109165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidtwco (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
| @@ -230,7 +230,7 @@ impl CanonicalizeMode for CanonicalizeUserTypeAnnotation { | |||
| r: ty::Region<'tcx>, | |||
| ) -> ty::Region<'tcx> { | |||
| match *r { | |||
| ty::ReEarlyBound(_) | ty::ReFree(_) | ty::ReErased | ty::ReStatic => r, | |||
| ty::ReEarlyBound(_) | ty::ReFree(_) | ty::ReErased | ty::ReStatic | ty::ReError(_) => r, | |||
| ty::ReVar(_) => canonicalizer.canonical_var_for_region_in_root_universe(r), | |||
| _ => { | |||
There was a problem hiding this comment.
Could this match be exhaustive?
| @@ -0,0 +1,15 @@ | |||
| // Regression test for #109072. | |||
| // Check that we don't ICE when canonicalizing user annotation. | |||
| // check-fail | |||
There was a problem hiding this comment.
check-fail is the default mode i think? don't think it's needed
davidtwco
approved these changes
Mar 16, 2023
aliemjay
force-pushed
the
fix-ice-annotation
branch
from
a21beb1 to
a42cbdb
Compare
|
@bors r=davidtwco |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (fadf164): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why not? we already allow
TyKind::Error.Fixes #109072.