Hermit: Remove floor symbol #107970
Merged
Hermit: Remove floor symbol #107970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This symbol should be provided by Hermit.
|
r? @thomcc (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
This was referenced Feb 12, 2023
|
Doesn't appear to be used anywhere, this is coming from the target's maintainer, and the target is tier3, so LGTM @bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 13, 2023
Rollup of 7 pull requests Successful merges: - rust-lang#107654 (reword descriptions of the deprecated int modules) - rust-lang#107915 (Add `array::map` benchmarks) - rust-lang#107961 (Avoid copy-pasting the `ilog` panic string in a bunch of places) - rust-lang#107962 (Add a doc note about why `Chain` is not `ExactSizeIterator`) - rust-lang#107966 (Update browser-ui-test version to 0.14.3) - rust-lang#107970 (Hermit: Remove floor symbol) - rust-lang#107973 (Fix unintentional UB in SIMD tests) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
bors bot
added a commit
to hermit-os/hermit-rs
that referenced
this pull request
Feb 14, 2023
406: Remove math from hermit-sys r=stlankes a=mkroening Related: * #406 * rust-lang/rust#107970 Co-authored-by: Martin Kröning <[email protected]>
bors bot
added a commit
to hermit-os/kernel
that referenced
this pull request
Feb 14, 2023
654: Provide math.h from hermit-builtins r=stlankes a=mkroening Related: * hermit-os/hermit-rs#406 * rust-lang/rust#107970 Co-authored-by: Martin Kröning <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This symbol should be provided by Hermit.
It was introduced in 2019 (#65167). Since 2020, Hermit provides these math functions on its own (hermit-os/hermit-rs#37). I think forgetting to move this to Hermit was merely an oversight.
Related:
CC: @stlankes