Remove QueryStorage::store_nocache

[Zoxc]

This method was added in #70674 but it doesn't seem to serve any purpose.

[rustbot]

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

[Zoxc]

The performance difference I saw locally was larger than expected given that it removes code in the cold path, maybe cutting down the lifetime of cache allowed LLVM to optimize better.

Benchmark	Before	After
	Time	Time	%
🟣 clap:check	1.8535s	1.8357s	-0.96%
🟣 hyper:check	0.2679s	0.2673s	-0.20%
🟣 syntex_syntax:check	6.4109s	6.4031s	-0.12%
🟣 syn:check	1.6480s	1.6420s	-0.36%
🟣 regex:check	1.0374s	1.0300s	-0.72%
Total	11.2176s	11.1780s	-0.35%
Summary	1.0000s	0.9953s	-0.47%

[cjgillot]

@bors try @rust-timer queue

[bors]

⌛ Trying commit a8dab9b543fc2f1c5879ece9897a1731bf7e9971 with merge 5b3e037ba365bec26d118b6a5280b099b5dffc39...

[bors]

☀️ Try build successful - checks-actions
Build commit: 5b3e037ba365bec26d118b6a5280b099b5dffc39 (5b3e037ba365bec26d118b6a5280b099b5dffc39)

[rust-timer]

Finished benchmarking commit (5b3e037ba365bec26d118b6a5280b099b5dffc39): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.3%]	5
Regressions ❌ (secondary)	0.3%	[0.2%, 0.5%]	7
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.1%	[-7.2%, -1.0%]	2
All ❌✅ (primary)	0.2%	[0.2%, 0.3%]	5

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.0%	[2.2%, 4.0%]	6
Regressions ❌ (secondary)	2.6%	[0.7%, 4.3%]	51
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.0%	[2.2%, 4.0%]	6

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	6.9%	[4.7%, 9.5%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.0%	[-4.0%, -4.0%]	1
All ❌✅ (primary)	-	-	0

[cjgillot]

r=me after rebase

[oli-obk]

@bors r=cjgillot

[bors]

📌 Commit d459840 has been approved by cjgillot

It is now in the queue for this repository.

[bors]

⌛ Testing commit d459840 with merge 9433ba6...

[bors]

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing 9433ba6 to master...

[rust-timer]

Finished benchmarking commit (9433ba6): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.4%	[1.2%, 1.5%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.7%	[-3.1%, -2.2%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.7%	[-3.1%, -2.2%]	2

Cycles

This benchmark run did not return any relevant results for this metric.