Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #106442

Merged
merged 17 commits into from
Jan 4, 2023
Merged

Rollup of 7 pull requests #106442

merged 17 commits into from
Jan 4, 2023

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Noratrieb and others added 17 commits December 30, 2022 16:14
This allows analyzing the output programatically; for example, finding
the item with the highest `total_estimate`.

I also took the liberty of adding `untracked` tests to `rustc_session` and documentation to the unstable book for `dump-mono-items`.
This allows regenerating `src/stage0.json` on changes to the tool,
without needing to hard-code the date in the source.
…, r=estebank

Suggest `impl Fn*` and `impl Future` in `-> _` return suggestions

Follow-up to rust-lang#106172, only the last commit is relevant. Can rebase once that PR is landed for easier review.

Suggests `impl Future` and `impl Fn{,Mut,Once}` in `-> _` return suggestions.

r? `@estebank`
Add JSON output to -Zdump-mono-stats

Follow-up to rust-lang#105481

r? `@lqd` cc `@wesleywiser`
Add codegen test for `Box::new(uninit)` of big arrays

Closes rust-lang#58201

r? `@RalfJung`
…=estebank

Note maximum integer literal for `IntLiteralTooLarge`

Closes rust-lang#105908

`@rustbot` label +A-diagnostics
…bini

Allow passing a specific date to `bump-stage0`

This allows regenerating `src/stage0.json` on changes to the tool, without needing to hard-code the date in the source. It was useful for rust-lang#106394, which added clippy to the list of required components.

r? `@pietroalbini`
Enable doctests for rustc_query_impl

doctests worked out of the box for query_impl on my local machine. Working towards rust-lang#99144
@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-testsuite Area: The testsuite used to check the correctness of rustc A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 4, 2023
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=7

@bors
Copy link
Contributor

bors commented Jan 4, 2023

📌 Commit 4e590b3 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 4, 2023
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 4, 2023
@bors
Copy link
Contributor

bors commented Jan 4, 2023

⌛ Testing commit 4e590b3 with merge 5c18bc6...

@bors
Copy link
Contributor

bors commented Jan 4, 2023

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 5c18bc6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 4, 2023
@bors bors merged commit 5c18bc6 into rust-lang:master Jan 4, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 4, 2023
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Perf Build Sha
#106436 eebccee47a52187ad1433d6c8a1f18781e508496
#106396 6fc0b92dd03d678c3801bdf695fdbff73cc43fb8
#106361 01a22fa9e9df5c6e83bda43e228fcde44acb39dc
#106327 b58b040aa5478ab49e2e262076a44f61b1137d5e
#106292 08a640bbbf8fbb7cfd7459ee4ee814e56d17ebd2
#106274 5faac21c844d8fe9e227319df764bc1a5e8a2ebe
#106200 3e00d5ab9524cb2615884eb4d4e7c78a77db13a6

previous master: ddad1e1f15

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5c18bc6): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.1% [2.0%, 2.3%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.0% [-2.0%, -2.0%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

@matthiaskrgr matthiaskrgr deleted the rollup-wivf7gh branch March 16, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-testsuite Area: The testsuite used to check the correctness of rustc A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants