-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework some predicates_of
/{Generic,Instantiated}Predicates
code
#106395
Conversation
r? @eholk (rustbot has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
9c4e665
to
7f9f279
Compare
@bors r+ |
📌 Commit 7f9f27911415de54055d82b369480d780a9092a0 has been approved by It is now in the queue for this repository. |
☔ The latest upstream changes (presumably #106696) made this pull request unmergeable. Please resolve the merge conflicts. |
7f9f279
to
90df86f
Compare
rebased @bors r=eholk |
⌛ Testing commit 90df86f with merge 123179ea234e0033a491ca458a6410725684eb1a... |
💔 Test failed - checks-actions |
@bors retry spurious network error
|
The job Click to see the possible cause of the failure (guessed by this bot)
|
☀️ Test successful - checks-actions |
Finished benchmarking commit (d12412c): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
I'll look into this. |
The PR that reverts the 4 commits in this one came back with neutral perf results: #106961 (comment) So... is it possible that this is just noise? |
instantiate_own
return an iterator, since it's a bit more efficient and easier to work withbound_{explicit,}_predicates_of
-- thesebound_
methods in particular were a bit awkward to work with sincety::GenericPredicates
already acts kinda like anEarlyBinder
with its owninstantiate_*
methods, and had only a few call sites anyways.IntoIterator
forInstantiatedPredicates
, since it's very commonly beingzip
'd together.