refactor: clean up `errors.rs` and `error_codes_check.rs` #106341

Ezrashaw · 2023-01-01T02:29:21Z

errors.rs is basically unused now, error_codes_check.rs is useful but not well commented, etc. It also doesn't check certain things which are certainly not correct. For example, E0505 has a UI test in src/test/ui/error-codes/ but that test actually outputs E0504?! Other issues like these exist. I've implemented these with "warnings" which are a bit rough around the edges but should be removed eventually.

r? @GuillaumeGomez (again not sure if you want to review but its relevant to you)

Move them into new `error_codes.rs` tidy check.

rustbot · 2023-01-01T02:29:30Z

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

Ezrashaw · 2023-01-01T02:49:13Z

The CI is failing because of a check ensuring error code explanations are not removed. I'm not a big fan of this, what help can outdated documentation be? I want guidance on this and then I'll remove that CI check.

compiler/rustc_error_codes/src/error_codes/E0729.md

GuillaumeGomez · 2023-01-01T16:16:10Z

This is a really nice improvements, thanks a lot for working on this. Once my comment is fixed, it'll be good to go!

src/tools/tidy/src/error_codes.rs

mejrs

I think the error messages are generally good 👍 I have some comments though

src/tools/tidy/src/error_codes.rs

mejrs · 2023-01-01T20:17:00Z

I checked it out locally and tidy spits out the following:

WARNING: 10 error codes are undocumented. This *will* become a hard error.
Found 505 error codes
WARNING: 36 error codes use the ignore header. This should not be used, add the error codes to the `IGNORE_DOCTEST_CHECK` constant instead. This *will* become a hard error.
WARNING: 36 error codes don't have a code example, all error codes are expected to have one (even if untested). This *will* become a hard error.
WARNING: 68 error codes are no longer emitted and should be removed entirely. This *will* become a hard error.
WARNING: 8 error codes have a UI test file, but don't contain their own error code!
WARNING: 272 error codes need to have at least one UI test in the `src/test/ui/error-codes/` directory`! This *will* become a hard error.
WARNING: 6 error codes are used when they are marked as "no longer emitted"
* 392 features
fmt check
Build completed successfully in 0:01:09

We shouldn't emit warnings like that unless it's the user's fault. There should be no "WARNING" in all caps and no "This will become a hard error."

I think it would be fine to have something like this as an opt-in (that would definitely be helpful for your followup PRs and anyone helping), but not by default.

Ezrashaw · 2023-01-01T20:23:34Z

I think it would be fine to have something like this as an opt-in (that would definitely be helpful for your followup PRs and anyone helping), but not by default.

~~Could that be hardcoded?~~ Nevermind, we can use --verbose. I'll also fix up all poor counter logic and stuff, we can just print 100s of messages if its opt-in.

mejrs · 2023-01-01T20:29:20Z

Nevermind, we can use --verbose

Or you could make a --pedantic setting. It's generally understood that if you enable something called pedantic that the errors may be terse.

Ezrashaw · 2023-01-01T20:30:47Z

tidy already has a bool for verbose in main.rs so I'll just use that. Pedantic implies failing the build but this is just supplementary information.

mejrs

It looks good, thanks for making the changes, I just have one final nit.

src/tools/tidy/src/error_codes.rs

Co-authored-by: Bruno Kolenbrander <[email protected]>

src/tools/tidy/src/errors.rs

GuillaumeGomez · 2023-01-02T22:25:08Z

Looks good to me, thanks for working on this! Do you see anything else @mejrs and @klensy ?

mejrs · 2023-01-06T19:15:29Z

Looks good to me, thanks for working on this! Do you see anything else @mejrs and @klensy ?

I'm happy with it :)

GuillaumeGomez · 2023-01-06T19:24:06Z

Then let's go!

@bors r=mejrs,klensy,GuillaumeGomez rollup

bors · 2023-01-06T19:24:07Z

📌 Commit c00ab4b has been approved by mejrs,klensy,GuillaumeGomez

It is now in the queue for this repository.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#106287 (Add some docs to `bug`, `span_bug` and `delay_span_bug`) - rust-lang#106341 (refactor: clean up `errors.rs` and `error_codes_check.rs`) - rust-lang#106453 (Improve include macro documentation) - rust-lang#106466 (Fix rustdoc source code rendering for `#[path = "../path/to/mod.rs"]` links) - rust-lang#106528 (Tiny formatting fix) - rust-lang#106534 (rustdoc-gui: Use new block syntax for define-function in goml scripts) - rust-lang#106542 (Add default and latest stable edition to --edition in rustc (attempt 2)) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

…aumeGomez Add some UI tests and reword error-code docs Added UI tests for `E0013` and `E0015`. Error code docs for `E0015` were a bit unclear (they referred to all non-const errors in const context, when only non-const functions applied), so I touched them up a bit. I also fixed up some issues in the new `error_codes.rs` tidy check (linked rust-lang#106341), that I overlooked previously. r? `@GuillaumeGomez`

…aumeGomez Add some UI tests and reword error-code docs Added UI tests for `E0013` and `E0015`. Error code docs for `E0015` were a bit unclear (they referred to all non-const errors in const context, when only non-const functions applied), so I touched them up a bit. I also fixed up some issues in the new `error_codes.rs` tidy check (linked rust-lang#106341), that I overlooked previously. r? ``@GuillaumeGomez``

refactor: clean up errors.rs and error_codes_check.rs

04b9038

Move them into new `error_codes.rs` tidy check.

rustbot assigned GuillaumeGomez Jan 1, 2023

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 1, 2023

This comment has been minimized.

Sign in to view

GuillaumeGomez reviewed Jan 1, 2023

View reviewed changes

compiler/rustc_error_codes/src/error_codes/E0729.md Show resolved Hide resolved

klensy reviewed Jan 1, 2023

View reviewed changes

src/tools/tidy/src/error_codes.rs Show resolved Hide resolved

mejrs reviewed Jan 1, 2023

View reviewed changes

src/tools/tidy/src/error_codes.rs Show resolved Hide resolved

src/tools/tidy/src/error_codes.rs Show resolved Hide resolved

src/tools/tidy/src/error_codes.rs Outdated Show resolved Hide resolved

src/tools/tidy/src/error_codes.rs Outdated Show resolved Hide resolved

Ezrashaw added 2 commits January 2, 2023 09:11

docs: revert removal of E0729

9618f64

use more paths in error codes

24671b7

fix CI error

def1b7c

fixup warnings

fafb18e

mejrs approved these changes Jan 1, 2023

View reviewed changes

src/tools/tidy/src/error_codes.rs Outdated Show resolved Hide resolved

Ezrashaw and others added 2 commits January 2, 2023 16:14

pattern destructure has_test

1f1dd5f

Co-authored-by: Bruno Kolenbrander <[email protected]>

fix CI

b7341db

GuillaumeGomez reviewed Jan 2, 2023

View reviewed changes

src/tools/tidy/src/errors.rs Show resolved Hide resolved

print highest error code

c00ab4b

GuillaumeGomez approved these changes Jan 2, 2023

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 6, 2023

matthiaskrgr mentioned this pull request Jan 6, 2023

Rollup of 7 pull requests #106544

Merged

bors merged commit 498216e into rust-lang:master Jan 7, 2023

rustbot added this to the 1.68.0 milestone Jan 7, 2023

Ezrashaw deleted the refactor-error-code-tidy-check branch January 7, 2023 04:10

Ezrashaw mentioned this pull request Jan 7, 2023

Add some UI tests and reword error-code docs #106557

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: clean up `errors.rs` and `error_codes_check.rs` #106341

refactor: clean up `errors.rs` and `error_codes_check.rs` #106341

Ezrashaw commented Jan 1, 2023

rustbot commented Jan 1, 2023

Ezrashaw commented Jan 1, 2023

This comment has been minimized.

GuillaumeGomez commented Jan 1, 2023

mejrs left a comment

mejrs commented Jan 1, 2023

Ezrashaw commented Jan 1, 2023 •

edited

Loading

mejrs commented Jan 1, 2023

Ezrashaw commented Jan 1, 2023

mejrs left a comment

GuillaumeGomez commented Jan 2, 2023

mejrs commented Jan 6, 2023

GuillaumeGomez commented Jan 6, 2023

bors commented Jan 6, 2023

refactor: clean up errors.rs and error_codes_check.rs #106341

refactor: clean up errors.rs and error_codes_check.rs #106341

Conversation

Ezrashaw commented Jan 1, 2023

rustbot commented Jan 1, 2023

Ezrashaw commented Jan 1, 2023

This comment has been minimized.

GuillaumeGomez commented Jan 1, 2023

mejrs left a comment

Choose a reason for hiding this comment

mejrs commented Jan 1, 2023

Ezrashaw commented Jan 1, 2023 • edited Loading

mejrs commented Jan 1, 2023

Ezrashaw commented Jan 1, 2023

mejrs left a comment

Choose a reason for hiding this comment

GuillaumeGomez commented Jan 2, 2023

mejrs commented Jan 6, 2023

GuillaumeGomez commented Jan 6, 2023

bors commented Jan 6, 2023

refactor: clean up `errors.rs` and `error_codes_check.rs` #106341

refactor: clean up `errors.rs` and `error_codes_check.rs` #106341

Ezrashaw commented Jan 1, 2023 •

edited

Loading