Silence knock-down errors on [type error] bindings
#106199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eholk (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
estebank
force-pushed
the
quiet-type-err-in-binding
branch
from
9d4297a to
e5bd7ce
Compare
This comment was marked as resolved.
This comment was marked as resolved.
estebank
force-pushed
the
quiet-type-err-in-binding
branch
from
e5bd7ce to
6e972ab
Compare
This comment has been minimized.
This comment has been minimized.
| @@ -1,9 +1,13 @@ | |||
| // The purpose of this test is not to validate the output of the compiler. | |||
| // Instead, it ensures the suggestion is generated without performing an arithmetic overflow. | |||
|
|
|||
| struct S; | |||
There was a problem hiding this comment.
Why did you change this UI test? I think the UI test was added to check for an ICE that resulted specifically from this combination of resolver errors.
There was a problem hiding this comment.
Because the error that produced the ICE would no longer emit with the correct propagation of [type error]. The relevant part seemed to be the error that I kept.
There was a problem hiding this comment.
Hm, I'm not sure if this modified UI test is "faithful" to the ICE anymore, either, though. I'm tempted to leave it as-is even if the error output turns into basically nothing. Either that, or we should just yeet this test completely..
I guess I don't care strongly any way.
estebank
force-pushed
the
quiet-type-err-in-binding
branch
from
6e972ab to
8e039b6
Compare
|
r=me |
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 28, 2022
…, r=compiler-errors Silence knock-down errors on `[type error]` bindings Fix rust-lang#56036, fix rust-lang#76589.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 28, 2022
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#106028 (docs/test: add UI test and long-form error docs for `E0461`) - rust-lang#106172 (Suggest `impl Iterator` when possible for `_` return type) - rust-lang#106173 (Deduplicate `op` methods) - rust-lang#106176 (Recover `fn` keyword as `Fn` trait in bounds) - rust-lang#106194 (rustdoc: combine common sidebar background color CSS rules) - rust-lang#106199 (Silence knock-down errors on `[type error]` bindings) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #56036, fix #76589.