Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 7 pull requests #105951

Merged
merged 17 commits into from
Dec 20, 2022
Merged

Rollup of 7 pull requests #105951

merged 17 commits into from
Dec 20, 2022

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

tmiasko and others added 17 commits December 17, 2022 18:23
@tmiasko
Replace visitor with a loop over blocks and statements
2a8513d
@tmiasko
Rename CleanupNonCodegenStatements to CleanupPostBorrowck
4c3efc7
@tmiasko
Remove false edges in CleanupPostBorrowck
62f9084
@tmiasko
./x.py test --bless
acaa2c1
@JakobDegen
Disable NormalizeArrayLen
4251289
@andersk
Update coerce_unsized tracking issue from rust-lang#27732 to rust-lan…
8c73ce6 
…g#18598

Issue rust-lang#27732 was closed as a duplicate of rust-lang#18598.

Signed-off-by: Anders Kaseorg <[email protected]>
@GuillaumeGomez
Improve description of struct-fields GUI test
babd174
@JohnTitor
Add regression test for rust-lang#102206
a115a59 
Signed-off-by: Yuki Okushi <[email protected]>
@JohnTitor
Add regression test for rust-lang#80816
17d7d71 
Signed-off-by: Yuki Okushi <[email protected]>
@JohnTitor
Add regression test for rust-lang#57404
8f88cec 
Signed-off-by: Yuki Okushi <[email protected]>
@matthiaskrgr
Rollup merge of rust-lang#105835 - tmiasko:cleanup-post-borrowck, r=J…
52fe5a1 
…akobDegen

Refactor post borrowck cleanup passes
@matthiaskrgr
Rollup merge of rust-lang#105930 - JakobDegen:nal-unsound, r=oli-obk
c3af456 
Disable `NormalizeArrayLen`

cc rust-lang#105929

r? mir-opt
@matthiaskrgr
Rollup merge of rust-lang#105938 - andersk:coerce_unsized-tracking, r…
ced6f38 
…=Dylan-DPC

Update coerce_unsized tracking issue from rust-lang#27732 to rust-lang#18598

Issue rust-lang#27732 was closed as a duplicate of rust-lang#18598.
@matthiaskrgr
Rollup merge of rust-lang#105939 - GuillaumeGomez:improve-description…
191a877 
…-gui-test, r=Dylan-DPC

Improve description of struct-fields GUI test

I moved the comment at the top of the file and clarified it a little bit.

r? `@notriddle`
@matthiaskrgr
Rollup merge of rust-lang#105943 - JohnTitor:issue-102206, r=compiler…
d6fbe79 
…-errors

Add regression test for rust-lang#102206

Closes rust-lang#102206
r? `@compiler-errors`
Signed-off-by: Yuki Okushi <[email protected]>
@matthiaskrgr
Rollup merge of rust-lang#105944 - JohnTitor:issue-80816, r=compiler-…
b149315 
…errors

Add regression test for rust-lang#80816

Closes rust-lang#80816
r? `@compiler-errors`
Signed-off-by: Yuki Okushi <[email protected]>
@matthiaskrgr
Rollup merge of rust-lang#105945 - JohnTitor:issue-57404, r=compiler-…
8db5dd4 
…errors

Add regression test for rust-lang#57404

r? `@compiler-errors`
Closes rust-lang#57404

Signed-off-by: Yuki Okushi <[email protected]>
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Dec 20, 2022
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=7

@bors
Copy link
Contributor

bors commented Dec 20, 2022

📌 Commit 8db5dd4 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2022
@bors
Copy link
Contributor

bors commented Dec 20, 2022

⌛ Testing commit 8db5dd4 with merge 65bd2a6...

@bors
Copy link
Contributor

bors commented Dec 20, 2022

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 65bd2a6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 20, 2022
@bors bors merged commit 65bd2a6 into rust-lang:master Dec 20, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 20, 2022
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Perf Build Sha
#105945 c7a470c366d0d8f37affde0aae7347f4cef93fa8
#105944 189428b5b2feff0dcb9b68bd7ebe3460dda6aff0
#105943 d8114a0a2550a0e8537182bf4e9d85d88d440536
#105939 152e86f37676084d6a8c7e12b8972e503656e915
#105938 080398496543ad226efb2c1cbdaefbb9bbf54e38
#105930 1c1a257df8e394f3f289667051dde4c9a3e4e9bd
#105835 b757c83e6aa36a1d935c468fefd0c48a2829ccc3

previous master: 8a746f4ac3

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

This was referenced Dec 20, 2022
Closed
Merged
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (65bd2a6): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.1% [1.0%, 1.2%] 2
Regressions ❌
(secondary)		 2.3% [2.1%, 2.7%] 6
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.1% [1.0%, 1.2%] 2

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -3.0% [-4.4%, -1.2%] 7
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -3.0% [-4.4%, -1.2%] 7

@rustbot rustbot added the perf-regression Performance regression. label Dec 20, 2022
@lqd
Copy link
Member

lqd commented Dec 20, 2022

These benchmarks are currently noisy: these regressions are the opposite of the next commit's results #105940 (comment)

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Dec 20, 2022
@matthiaskrgr matthiaskrgr deleted the rollup-aqxz888 branch December 22, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
10 participants
@matthiaskrgr @bors @rust-timer @lqd @rustbot @tmiasko @JakobDegen @andersk @GuillaumeGomez @JohnTitor