libstd: Change all ~fn()s to procs in the standard library.
#10554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if enlist_success { | ||
| if indestructible { | ||
| do unkillable { f() } | ||
| do unkillable { f_cell.take()() } |
There was a problem hiding this comment.
aww I thought proc was supposed to remove cells :(
There was a problem hiding this comment.
unkillable needs to become RAII. Then we can remove the cell.
|
r=me with the leak fixed |
This makes `Cell`s no longer necessary in most cases.
|
I think this landed as #10561, closing to save on bors work. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 6, 2023
…r=Jarcho
Make redundant_async_block a more complete late pass
This lets us detect more complex situations: `async { x.await }` is simplified into `x` if:
- `x` is an expression without side-effect
- or `x` is an `async` block itself
In both cases, no part of the `async` expression can be part of a macro expansion.
Fixes rust-lang#10509.
Fixes rust-lang#10525.
changelog: [`redundant_async_block`] Do not lint expressions with side effects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
Cells no longer necessary in most cases.r? @alexcrichton